AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[interpreter][stubs] Don't modify FLAG_csa_verify flag to make TSAN happy.

Browse Source 
BUG=

Review-Url: https://codereview.chromium.org/2568173002
Cr-Commit-Position: refs/heads/master@{#41653}
This commit is contained in:
ishell 2016-12-12 09:02:51 -08:00 committed by Commit bot
parent 257793e3f5
commit 769442a1b8
3 changed files with 1 additions and 23 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/builtins/builtins.cc
View File

@ -108,14 +108,7 @@ Code* BuildWithCodeStubAssemblerCS(Isolate* isolate,
DCHECK_LE(0, descriptor.GetRegisterParameterCount()); DCHECK_LE(0, descriptor.GetRegisterParameterCount());
compiler::CodeAssemblerState state(isolate, &zone, descriptor, flags, name); compiler::CodeAssemblerState state(isolate, &zone, descriptor, flags, name);
generator(&state); generator(&state);
// TODO(ishell): remove this when code stub assembler graphs verification
// is enabled for all stubs.
bool saved_csa_verify = FLAG_csa_verify;
// Enable verification only in mksnapshot.
FLAG_csa_verify = DEBUG_BOOL && FLAG_startup_blob != nullptr;
Handle<Code> code = compiler::CodeAssembler::GenerateCode(&state); Handle<Code> code = compiler::CodeAssembler::GenerateCode(&state);
FLAG_csa_verify = saved_csa_verify;
PostBuildProfileAndTracing(isolate, *code, name); PostBuildProfileAndTracing(isolate, *code, name);
return *code; return *code;
} }

10
src/code-stubs.cc
View File

@ -437,15 +437,7 @@ Handle<Code> TurboFanCodeStub::GenerateCode() {
compiler::CodeAssemblerState state(isolate(), &zone, descriptor, compiler::CodeAssemblerState state(isolate(), &zone, descriptor,
GetCodeFlags(), name); GetCodeFlags(), name);
GenerateAssembly(&state); GenerateAssembly(&state);
return compiler::CodeAssembler::GenerateCode(&state);
// TODO(ishell): remove this when code stub assembler graphs verification
// is enabled for all stubs.
bool saved_csa_verify = FLAG_csa_verify;
// Enable verification only in mksnapshot.
FLAG_csa_verify = DEBUG_BOOL && FLAG_startup_blob != nullptr;
Handle<Code> code = compiler::CodeAssembler::GenerateCode(&state);
FLAG_csa_verify = saved_csa_verify;
return code;
} }
#define ACCESSOR_ASSEMBLER(Name) \ #define ACCESSOR_ASSEMBLER(Name) \

7
src/interpreter/interpreter.cc
View File

@ -98,12 +98,6 @@ void Interpreter::InstallBytecodeHandler(Zone* zone, Bytecode bytecode,
BytecodeGeneratorFunc generator) { BytecodeGeneratorFunc generator) {
if (!Bytecodes::BytecodeHasHandler(bytecode, operand_scale)) return; if (!Bytecodes::BytecodeHasHandler(bytecode, operand_scale)) return;
// TODO(ishell): remove this when code stub assembler graphs verification
// is enabled for all stubs.
bool sav_csa_verify = FLAG_csa_verify;
// Enable verification only in mksnapshot.
FLAG_csa_verify = DEBUG_BOOL && FLAG_startup_blob != nullptr;
InterpreterDispatchDescriptor descriptor(isolate_); InterpreterDispatchDescriptor descriptor(isolate_);
compiler::CodeAssemblerState state( compiler::CodeAssemblerState state(
isolate_, zone, descriptor, Code::ComputeFlags(Code::BYTECODE_HANDLER), isolate_, zone, descriptor, Code::ComputeFlags(Code::BYTECODE_HANDLER),
@ -118,7 +112,6 @@ void Interpreter::InstallBytecodeHandler(Zone* zone, Bytecode bytecode,
CodeEventListener::BYTECODE_HANDLER_TAG, CodeEventListener::BYTECODE_HANDLER_TAG,
AbstractCode::cast(*code), AbstractCode::cast(*code),
Bytecodes::ToString(bytecode, operand_scale).c_str())); Bytecodes::ToString(bytecode, operand_scale).c_str()));
FLAG_csa_verify = sav_csa_verify;
} }
Code* Interpreter::GetBytecodeHandler(Bytecode bytecode, Code* Interpreter::GetBytecodeHandler(Bytecode bytecode,