AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[Interpreter] Ensure we save the BytecodeArray register properly in InterpreterEntryTrampoline builtin.

Browse Source 
Ensure that we save the BytecodeArray register in the InterpreterEntryTrampoline
before calling out to the kStackGuard runtime function.

BUG=v8:4280
LOG=N

Review URL: https://codereview.chromium.org/1426863005

Cr-Commit-Position: refs/heads/master@{#31650}
This commit is contained in:
rmcilroy 2015-10-29 04:47:06 -07:00 committed by Commit bot
parent ce84bb2d3d
commit 76d730b9b2
8 changed files with 16 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/arm/builtins-arm.cc
View File

@ -917,7 +917,9 @@ void Builtins::Generate_InterpreterEntryTrampoline(MacroAssembler* masm) {
__ LoadRoot(ip, Heap::kStackLimitRootIndex);
__ cmp(sp, Operand(ip));
__ b(hs, &ok);
__ push(kInterpreterBytecodeArrayRegister);
__ CallRuntime(Runtime::kStackGuard, 0);
__ pop(kInterpreterBytecodeArrayRegister);
__ bind(&ok);
}

2
src/arm64/builtins-arm64.cc
View File

@ -942,7 +942,9 @@ void Builtins::Generate_InterpreterEntryTrampoline(MacroAssembler* masm) {
Label ok;
__ CompareRoot(jssp, Heap::kStackLimitRootIndex);
__ B(hs, &ok);
__ Push(kInterpreterBytecodeArrayRegister);
__ CallRuntime(Runtime::kStackGuard, 0);
__ Pop(kInterpreterBytecodeArrayRegister);
__ Bind(&ok);
}

2
src/ia32/builtins-ia32.cc
View File

@ -654,7 +654,9 @@ void Builtins::Generate_InterpreterEntryTrampoline(MacroAssembler* masm) {
ExternalReference::address_of_stack_limit(masm->isolate());
__ cmp(esp, Operand::StaticVariable(stack_limit));
__ j(above_equal, &ok);
__ push(kInterpreterBytecodeArrayRegister);
__ CallRuntime(Runtime::kStackGuard, 0);
__ pop(kInterpreterBytecodeArrayRegister);
__ bind(&ok);
}

2
src/mips/builtins-mips.cc
View File

@ -917,7 +917,9 @@ void Builtins::Generate_InterpreterEntryTrampoline(MacroAssembler* masm) {
Label ok;
__ LoadRoot(at, Heap::kStackLimitRootIndex);
__ Branch(&ok, hs, sp, Operand(at));
__ push(kInterpreterBytecodeArrayRegister);
__ CallRuntime(Runtime::kStackGuard, 0);
__ pop(kInterpreterBytecodeArrayRegister);
__ bind(&ok);
}

2
src/mips64/builtins-mips64.cc
View File

@ -913,7 +913,9 @@ void Builtins::Generate_InterpreterEntryTrampoline(MacroAssembler* masm) {
Label ok;
__ LoadRoot(at, Heap::kStackLimitRootIndex);
__ Branch(&ok, hs, sp, Operand(at));
__ push(kInterpreterBytecodeArrayRegister);
__ CallRuntime(Runtime::kStackGuard, 0);
__ pop(kInterpreterBytecodeArrayRegister);
__ bind(&ok);
}

2
src/ppc/builtins-ppc.cc
View File

@ -915,7 +915,9 @@ void Builtins::Generate_InterpreterEntryTrampoline(MacroAssembler* masm) {
__ LoadRoot(r0, Heap::kStackLimitRootIndex);
__ cmp(sp, r0);
__ bge(&ok);
__ push(kInterpreterBytecodeArrayRegister);
__ CallRuntime(Runtime::kStackGuard, 0);
__ pop(kInterpreterBytecodeArrayRegister);
__ bind(&ok);
}

2
src/x64/builtins-x64.cc
View File

@ -722,7 +722,9 @@ void Builtins::Generate_InterpreterEntryTrampoline(MacroAssembler* masm) {
Label ok;
__ CompareRoot(rsp, Heap::kStackLimitRootIndex);
__ j(above_equal, &ok, Label::kNear);
__ Push(kInterpreterBytecodeArrayRegister);
__ CallRuntime(Runtime::kStackGuard, 0);
__ Pop(kInterpreterBytecodeArrayRegister);
__ bind(&ok);
}

2
src/x87/builtins-x87.cc
View File

@ -654,7 +654,9 @@ void Builtins::Generate_InterpreterEntryTrampoline(MacroAssembler* masm) {
ExternalReference::address_of_stack_limit(masm->isolate());
__ cmp(esp, Operand::StaticVariable(stack_limit));
__ j(above_equal, &ok);
__ push(kInterpreterBytecodeArrayRegister);
__ CallRuntime(Runtime::kStackGuard, 0);
__ pop(kInterpreterBytecodeArrayRegister);
__ bind(&ok);
}