AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[wasm-simd][ia32] Fix DCHECK in f64x2.extract_lane

Browse Source 
f64x2.extract_lane can only extract lane 0 or 1. Fix the DCHECK to check
for the appropriate lane values.

Change-Id: I62d5e34ce01e0fa66609fb1fed7979bf2782bb74
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2589057
Reviewed-by: Bill Budge <bbudge@chromium.org>
Commit-Queue: Zhi An Ng <zhin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#71787}
This commit is contained in:
Zhi An Ng 2020-12-14 03:46:49 +00:00 committed by Commit Bot
parent 8656a594ab
commit 76f9ee6137
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/compiler/backend/ia32/code-generator-ia32.cc
View File

@ -1999,7 +1999,7 @@ CodeGenerator::CodeGenResult CodeGenerator::AssembleArchInstruction(
XMMRegister dst = i.OutputDoubleRegister();
int8_t lane = i.InputInt8(1);
if (lane != 0) {
DCHECK_LT(lane, 4);
DCHECK_EQ(lane, 1);
__ shufpd(dst, dst, lane);
}
break;
@ -2012,7 +2012,7 @@ CodeGenerator::CodeGenResult CodeGenerator::AssembleArchInstruction(
if (lane == 0) {
if (dst != src) __ vmovapd(dst, src);
} else {
DCHECK_LT(lane, 4);
DCHECK_EQ(lane, 1);
__ vshufpd(dst, src, src, lane);
}
break;