From 7787ed20070df8b39a503812e3e570a766d701ec Mon Sep 17 00:00:00 2001 From: Seth Brenith Date: Fri, 3 Jun 2022 15:56:29 -0700 Subject: [PATCH] Build cctest while building V8 I noticed in a recent build that C++ files from cctest didn't start compiling until after several slow non-parallel tasks such as running mksnapshot and linking v8_for_testing. I don't see any reason that cctest sources should wait for those tasks, so in this change I propose adjusting the build dependencies for more parallelism. Change-Id: I2472117c8555ac397fa1232954c8b699d6429d38 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3690170 Reviewed-by: Nico Hartmann Commit-Queue: Seth Brenith Cr-Commit-Position: refs/heads/main@{#80976} --- test/cctest/BUILD.gn | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/test/cctest/BUILD.gn b/test/cctest/BUILD.gn index d3304a714f..aa606194dd 100644 --- a/test/cctest/BUILD.gn +++ b/test/cctest/BUILD.gn @@ -16,7 +16,13 @@ v8_executable("cctest") { sources = [ "cctest.cc" ] - deps = [ ":cctest_sources" ] + deps = [ + ":cctest_sources", + "../..:v8_for_testing", + "../..:v8_libbase", + "../..:v8_libplatform", + "../../tools/debug_helper:v8_debug_helper", + ] data_deps = [ "../../tools:v8_testrunner" ] @@ -340,10 +346,6 @@ v8_source_set("cctest_sources") { public_deps = [ ":cctest_headers", "..:common_test_headers", - "../..:v8_for_testing", - "../..:v8_libbase", - "../..:v8_libplatform", - "../../tools/debug_helper:v8_debug_helper", "//build/win:default_exe_manifest", ]