From 77dcc8dac5896a94be2fcbdb5a6fff0e82f48441 Mon Sep 17 00:00:00 2001 From: "mstarzinger@chromium.org" Date: Tue, 27 Nov 2012 12:52:51 +0000 Subject: [PATCH] Make unit tests that fill new-space work under stress. This makes sure that unit tests that try to fill up the new-space work on the GC stress buildbots as well. R=yangguo@chromium.org TEST=cctest/test-heap --gc-interval=500 --stress-compaction Review URL: https://codereview.chromium.org/11416200 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@13065 ce2b1a6d-e550-0410-aec6-3dcde31c8c00 --- test/cctest/test-heap.cc | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/test/cctest/test-heap.cc b/test/cctest/test-heap.cc index a51b37ebae..f5bac2c5de 100644 --- a/test/cctest/test-heap.cc +++ b/test/cctest/test-heap.cc @@ -1944,7 +1944,7 @@ TEST(OptimizedAllocationAlwaysInNewSpace) { if (!i::V8::UseCrankshaft() || i::FLAG_always_opt) return; v8::HandleScope scope; - FillUpNewSpace(HEAP->new_space()); + SimulateFullSpace(HEAP->new_space()); AlwaysAllocateScope always_allocate; v8::Local res = CompileRun( "function c(x) {" @@ -2153,14 +2153,9 @@ TEST(Regress2237) { // Generate a sliced string that is based on the above parent and // lives in old-space. - FillUpNewSpace(HEAP->new_space()); + SimulateFullSpace(HEAP->new_space()); AlwaysAllocateScope always_allocate; - Handle t; - // TODO(mstarzinger): Unfortunately FillUpNewSpace() still leaves - // some slack, so we need to allocate a few sliced strings. - for (int i = 0; i < 16; i++) { - t = FACTORY->NewProperSubString(s, 5, 35); - } + Handle t = FACTORY->NewProperSubString(s, 5, 35); CHECK(t->IsSlicedString()); CHECK(!HEAP->InNewSpace(*t)); *slice.location() = *t.location();