AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

Revert "Update GN configs for v8_perf target to allow running perf tests in swarming"

Browse Source 
This reverts commit f0a9a6a5ad.

Reason for revert: Breaks V8 Android GN (dbg)
https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Android%20GN%20%28dbg%29/12328

Original change's description:
> Update GN configs for v8_perf target to allow running perf tests in swarming
> 
> This will allow us to migrate our deprecated configs to android_docker.
> 
> R=​machenbach@chromium.org
> 
> Bug: chromium:838864
> Change-Id: I5f7db648520847aa2077e9fc2a5970e63daa9a50
> Reviewed-on: https://chromium-review.googlesource.com/1131944
> Reviewed-by: Michael Achenbach <machenbach@chromium.org>
> Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#54441}

TBR=machenbach@chromium.org,sergiyb@chromium.org

Change-Id: I81ecd49ed69f2161931fce3836ba66462a101a25
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:838864
Reviewed-on: https://chromium-review.googlesource.com/1136716
Reviewed-by: Bill Budge <bbudge@chromium.org>
Commit-Queue: Bill Budge <bbudge@chromium.org>
Cr-Commit-Position: refs/heads/master@{#54442}
This commit is contained in:
Bill Budge 2018-07-13 17:12:05 +00:00 committed by Commit Bot
parent f0a9a6a5ad
commit 782b793bb6
2 changed files with 0 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
DEPS
View File

@ -51,8 +51,6 @@ deps = {
Var('chromium_url') + '/chromium/src/third_party/jinja2.git' + '@' + 'b41863e42637544c2941b574c7877d3e1f663e25',
'v8/third_party/markupsafe':
Var('chromium_url') + '/chromium/src/third_party/markupsafe.git' + '@' + '8f45f5cfa0009d2a70589bcda0349b8cb2b72783',
'v8/third_party/proguard':
Var('chromium_url') + '/chromium/src/third_party/proguard.git' + '@' + 'eba7a98d98735b2cc65c54d36baa5c9b46fe4f8e',
'v8/tools/swarming_client':
Var('chromium_url') + '/infra/luci/client-py.git' + '@' + '9a518d097dca20b7b00ce3bdfc5d418ccc79893a',
'v8/test/benchmarks/data':

11
test/BUILD.gn
View File

@ -49,28 +49,17 @@ group("v8_perf") {
data = [
"../tools/run_perf.py",
# TODO(machenbach): These files are referenced by the perf runner.
# They should be transformed into a proper python module.
"../tools/testrunner/local/command.py",
"../tools/testrunner/local/utils.py",
"../tools/testrunner/objects/output.py",
# This is often used to trigger performance bots. We include it in the
# isolate to not get these builds deduped.
"../tools/whitespace.txt",
"js-perf-test/",
"memory/",
]
if (is_android) {
data_deps += [ "../build/android:test_runner_py" ]
data += [
# This is used by run_perf.py, but not included by test_runner_py above.
"../third_party/catapult/devil/devil/android/perf/",
]
}
}
group("v8_bot_default") {