Revert "[build] Fix gn check failures in v8/third_party"

This reverts commit e13a744a45.

Reason for revert: breaks perfetto:
https://ci.chromium.org/p/v8/builders/ci/V8%20Linux64%20-%20debug%20-%20perfetto%20-%20builder/12849

Original change's description:
> [build] Fix gn check failures in v8/third_party
>
> This removes the blanket exclusion for third_party but leaves
> third_party/icu excluded (which is the same as chrome).
>
> Most fixed issues are to do with previously removed header files and
> missing dependencies.
>
> Bug: v8:7330
> Change-Id: I7e634e35c0620a1f3db9aba01119921e4f781e3e
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2856838
> Auto-Submit: Dan Elphick <delphick@chromium.org>
> Reviewed-by: Michael Achenbach <machenbach@chromium.org>
> Commit-Queue: Michael Achenbach <machenbach@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#74295}

Bug: v8:7330
Change-Id: I05cf897c0aeb6bf87f9889b878358c0d02600081
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2862767
Auto-Submit: Michael Achenbach <machenbach@chromium.org>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#74300}
This commit is contained in:
Michael Achenbach 2021-04-30 12:20:39 +00:00 committed by V8 LUCI CQ
parent bdfd5e2207
commit 78dbc1439d
4 changed files with 15 additions and 12 deletions

2
.gn
View File

@ -16,7 +16,7 @@ no_check_targets = [
"//:v8_internal_headers", "//:v8_internal_headers",
"//src/inspector:inspector", "//src/inspector:inspector",
"//test/cctest:cctest_sources", "//test/cctest:cctest_sources",
"//third_party/icu:*", "//third_party/*",
] ]
# These are the list of GN files that run exec_script. This whitelist exists # These are the list of GN files that run exec_script. This whitelist exists

View File

@ -36,6 +36,7 @@ if (v8_enable_google_benchmark) {
"src/src/counter.cc", "src/src/counter.cc",
"src/src/counter.h", "src/src/counter.h",
"src/src/csv_reporter.cc", "src/src/csv_reporter.cc",
"src/src/cycle_clock.h",
"src/src/internal_macros.h", "src/src/internal_macros.h",
"src/src/json_reporter.cc", "src/src/json_reporter.cc",
"src/src/log.h", "src/src/log.h",

View File

@ -51,6 +51,8 @@ config("gmock_config") {
source_set("gtest") { source_set("gtest") {
testonly = true testonly = true
sources = [ sources = [
# TODO(crbug.com/829773): Remove this after transitioning off <tr1/tuple>.
"custom/gmock/internal/custom/gmock-port.h",
"src/googletest/include/gtest/gtest-death-test.h", "src/googletest/include/gtest/gtest-death-test.h",
"src/googletest/include/gtest/gtest-matchers.h", "src/googletest/include/gtest/gtest-matchers.h",
"src/googletest/include/gtest/gtest-message.h", "src/googletest/include/gtest/gtest-message.h",
@ -64,9 +66,12 @@ source_set("gtest") {
"src/googletest/include/gtest/internal/gtest-death-test-internal.h", "src/googletest/include/gtest/internal/gtest-death-test-internal.h",
"src/googletest/include/gtest/internal/gtest-filepath.h", "src/googletest/include/gtest/internal/gtest-filepath.h",
"src/googletest/include/gtest/internal/gtest-internal.h", "src/googletest/include/gtest/internal/gtest-internal.h",
"src/googletest/include/gtest/internal/gtest-linked_ptr.h",
"src/googletest/include/gtest/internal/gtest-param-util-generated.h",
"src/googletest/include/gtest/internal/gtest-param-util.h", "src/googletest/include/gtest/internal/gtest-param-util.h",
"src/googletest/include/gtest/internal/gtest-port.h", "src/googletest/include/gtest/internal/gtest-port.h",
"src/googletest/include/gtest/internal/gtest-string.h", "src/googletest/include/gtest/internal/gtest-string.h",
"src/googletest/include/gtest/internal/gtest-tuple.h",
"src/googletest/include/gtest/internal/gtest-type-util.h", "src/googletest/include/gtest/internal/gtest-type-util.h",
#"src/googletest/src/gtest-all.cc", # Not needed by our build. #"src/googletest/src/gtest-all.cc", # Not needed by our build.
@ -124,16 +129,22 @@ source_set("gmock") {
"src/googlemock/include/gmock/gmock-actions.h", "src/googlemock/include/gmock/gmock-actions.h",
"src/googlemock/include/gmock/gmock-cardinalities.h", "src/googlemock/include/gmock/gmock-cardinalities.h",
"src/googlemock/include/gmock/gmock-function-mocker.h", "src/googlemock/include/gmock/gmock-function-mocker.h",
"src/googlemock/include/gmock/gmock-generated-actions.h",
"src/googlemock/include/gmock/gmock-generated-nice-strict.h",
"src/googlemock/include/gmock/gmock-matchers.h", "src/googlemock/include/gmock/gmock-matchers.h",
"src/googlemock/include/gmock/gmock-more-actions.h", "src/googlemock/include/gmock/gmock-more-actions.h",
"src/googlemock/include/gmock/gmock-more-matchers.h", "src/googlemock/include/gmock/gmock-more-matchers.h",
"src/googlemock/include/gmock/gmock-nice-strict.h", "src/googlemock/include/gmock/gmock-nice-strict.h",
"src/googlemock/include/gmock/gmock-spec-builders.h", "src/googlemock/include/gmock/gmock-spec-builders.h",
"src/googlemock/include/gmock/gmock.h", "src/googlemock/include/gmock/gmock.h",
"src/googlemock/include/gmock/internal/gmock-generated-internal-utils.h",
"src/googlemock/include/gmock/internal/gmock-internal-utils.h", "src/googlemock/include/gmock/internal/gmock-internal-utils.h",
"src/googlemock/include/gmock/internal/gmock-port.h", "src/googlemock/include/gmock/internal/gmock-port.h",
"src/googlemock/include/gmock/internal/gmock-pp.h", "src/googlemock/include/gmock/internal/gmock-pp.h",
# gmock helpers.
"custom/gmock/internal/custom/gmock-port.h",
#"src/googlemock/src/gmock-all.cc", # Not needed by our build. #"src/googlemock/src/gmock-all.cc", # Not needed by our build.
"src/googlemock/src/gmock-cardinalities.cc", "src/googlemock/src/gmock-cardinalities.cc",
"src/googlemock/src/gmock-internal-utils.cc", "src/googlemock/src/gmock-internal-utils.cc",
@ -155,8 +166,6 @@ source_set("gmock") {
":gmock_config", ":gmock_config",
":gtest_config", ":gtest_config",
] ]
deps = [ ":gtest" ]
} }
# Do NOT depend on this directly. Use //testing/gmock:gmock_main instead. # Do NOT depend on this directly. Use //testing/gmock:gmock_main instead.
@ -164,8 +173,5 @@ source_set("gmock") {
static_library("gmock_main") { static_library("gmock_main") {
testonly = true testonly = true
sources = [ "src/googlemock/src/gmock_main.cc" ] sources = [ "src/googlemock/src/gmock_main.cc" ]
deps = [ deps = [ ":gmock" ]
":gmock",
":gtest",
]
} }

View File

@ -5,10 +5,7 @@
import("../../gni/v8.gni") import("../../gni/v8.gni")
config("crdtp_config") { config("crdtp_config") {
visibility = [ visibility = [ "../../src/inspector:*", ":*" ]
":*",
"../../src/inspector:*",
]
configs = [ "../../:internal_config" ] configs = [ "../../:internal_config" ]
include_dirs = [ "../../include" ] include_dirs = [ "../../include" ]
} }
@ -49,7 +46,6 @@ v8_source_set("crdtp_platform") {
"crdtp/json_platform_v8.cc", "crdtp/json_platform_v8.cc",
] ]
public_deps = [ "../..:v8_libbase" ] public_deps = [ "../..:v8_libbase" ]
deps = [ "../../:v8_internal_headers" ]
configs = [ ":crdtp_config" ] configs = [ ":crdtp_config" ]
} }