[cleanup] Improve dependency handling in gn targets

This is a step towards making gn check pass on v8 without third_party

Change-Id: I6a256d65159695e2ba2a5d44c0437cac9b28aa3a
Bug: v8:8834, v8:8855
Reviewed-on: https://chromium-review.googlesource.com/c/1475460
Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
Cr-Commit-Position: refs/heads/master@{#59641}

BUILD.gn

@@ -3618,6 +3618,7 @@ if (is_component_build) {
     public_deps = [
       ":torque_base",
       ":v8_base",
+      ":v8_headers",
       ":v8_maybe_snapshot",
     ]
 

src/inspector/BUILD.gn

@@ -68,9 +68,26 @@ config("inspector_config") {
   include_dirs = [ "../../include" ]
 }
 
+v8_header_set("inspector_test_headers") {
+  configs = [ ":inspector_config" ]
+
+  public_deps = [
+    "../..:v8_headers",
+  ]
+
+  sources = [
+    "test-interface.h",
+  ]
+}
+
 v8_source_set("inspector") {
   deps = [
     ":protocol_generated_sources",
+    "../..:v8_version",
+  ]
+
+  public_deps = [
+    ":inspector_test_headers",
   ]
 
   configs = [ ":inspector_config" ]
@@ -96,7 +113,6 @@ v8_source_set("inspector") {
     "string-util.cc",
     "string-util.h",
     "test-interface.cc",
-    "test-interface.h",
     "v8-console-agent-impl.cc",
     "v8-console-agent-impl.h",
     "v8-console-message.cc",

test/cctest/BUILD.gn

@@ -43,6 +43,19 @@ v8_executable("cctest") {
   }
 }
 
+v8_header_set("cctest_headers") {
+  testonly = true
+
+  configs = [
+    "../..:external_config",
+    "../..:internal_config_base",
+  ]
+
+  sources = [
+    "cctest.h",
+  ]
+}
+
 v8_source_set("cctest_sources") {
   testonly = true
 
@@ -55,7 +68,6 @@ v8_source_set("cctest_sources") {
     "../common/wasm/test-signatures.h",
     "../common/wasm/wasm-macro-gen.h",
     "cctest.cc",
-    "cctest.h",
     "compiler/c-signature.h",
     "compiler/call-tester.h",
     "compiler/code-assembler-tester.h",
@@ -356,6 +368,7 @@ v8_source_set("cctest_sources") {
   ]
 
   public_deps = [
+    ":cctest_headers",
     ":resources",
     "..:common_test_headers",
     "../..:v8_initializers",
@@ -440,6 +453,8 @@ action("resources") {
 }
 
 v8_executable("generate-bytecode-expectations") {
+  testonly = true
+
   sources = [
     "interpreter/bytecode-expectations-printer.cc",
     "interpreter/bytecode-expectations-printer.h",
@@ -452,6 +467,7 @@ v8_executable("generate-bytecode-expectations") {
   ]
 
   deps = [
+    ":cctest_headers",
     "../..:v8",
     "../..:v8_libbase",
     "../..:v8_libplatform",

test/inspector/BUILD.gn

@@ -24,6 +24,7 @@ v8_executable("inspector-test") {
     "../..:v8",
     "../..:v8_libbase",
     "../..:v8_libplatform",
+    "../../src/inspector:inspector_test_headers",
     "//build/win:default_exe_manifest",
   ]