AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[compiler] Replace HeapNumberData with direct reads

Browse Source 
Bug: v8:7790
Change-Id: I3fbbbd36900146111f83596fd6615a2e4a4f5d33
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2362952
Commit-Queue: Georg Neis <neis@chromium.org>
Reviewed-by: Santiago Aboy Solanes <solanes@chromium.org>
Reviewed-by: Nico Hartmann <nicohartmann@chromium.org>
Cr-Commit-Position: refs/heads/master@{#69474}
This commit is contained in:
Georg Neis 2020-08-18 15:30:05 +02:00 committed by Commit Bot
parent 7b9a0c20f3
commit 7964ac8698
2 changed files with 4 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/compiler/heap-refs.h
View File

@ -88,7 +88,6 @@ enum class OddballType : uint8_t {
V(FeedbackVector) \
V(FixedArrayBase) \
V(FunctionTemplateInfo) \
V(HeapNumber) \
V(JSReceiver) \
V(Map) \
V(Name) \
@ -99,7 +98,9 @@ enum class OddballType : uint8_t {
/* Subtypes of Object */ \
V(HeapObject)
#define HEAP_BROKER_NEVER_SERIALIZED_OBJECT_LIST(V) V(ScopeInfo)
#define HEAP_BROKER_NEVER_SERIALIZED_OBJECT_LIST(V) \
V(HeapNumber) \
V(ScopeInfo)
class CompilationDependencies;
struct FeedbackSource;

14
src/compiler/js-heap-broker.cc
View File

@ -686,18 +686,6 @@ class JSRegExpData : public JSObjectData {
ObjectData* last_index_ = nullptr;
};
class HeapNumberData : public HeapObjectData {
public:
HeapNumberData(JSHeapBroker* broker, ObjectData** storage,
Handle<HeapNumber> object)
: HeapObjectData(broker, storage, object), value_(object->value()) {}
double value() const { return value_; }
private:
double const value_;
};
class ContextData : public HeapObjectData {
public:
ContextData(JSHeapBroker* broker, ObjectData** storage,
@ -3826,7 +3814,7 @@ base::Optional<ObjectRef> JSArrayRef::GetOwnCowElement(
double HeapNumberRef::value() const {
IF_ACCESS_FROM_HEAP_C(HeapNumber, value);
return data()->AsHeapNumber()->value();
UNREACHABLE();
}
uint64_t BigIntRef::AsUint64() const {