Remove overzealous check from %OptimizeFunctionOnNextCall.

R=titzer@chromium.org

Review URL: https://codereview.chromium.org/863443003

Cr-Commit-Position: refs/heads/master@{#26142}
This commit is contained in:
mstarzinger 2015-01-19 07:51:50 -08:00 committed by Commit bot
parent 396381f944
commit 79748e3f7c
3 changed files with 32 additions and 5 deletions

View File

@ -64,11 +64,6 @@ RUNTIME_FUNCTION(Runtime_OptimizeFunctionOnNextCall) {
// If the function is already optimized, just return. // If the function is already optimized, just return.
if (function->IsOptimized()) return isolate->heap()->undefined_value(); if (function->IsOptimized()) return isolate->heap()->undefined_value();
// If the function cannot optimized, just return.
if (function->shared()->optimization_disabled()) {
return isolate->heap()->undefined_value();
}
function->MarkForOptimization(); function->MarkForOptimization();
Code* unoptimized = function->shared()->code(); Code* unoptimized = function->shared()->code();

View File

@ -0,0 +1,23 @@
// Copyright 2015 the V8 project authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
// Flags: --allow-natives-syntax --turbo-filter=*
function foo() {
with ({ value:"fooed" }) { return value; }
}
%OptimizeFunctionOnNextCall(foo);
assertEquals("fooed", foo());
assertOptimized(foo);
function bar() {
with ({ value:"bared" }) { return value; }
}
assertEquals("bared", bar());
%OptimizeFunctionOnNextCall(bar);
assertEquals("bared", bar());
// TODO(mstarzinger): Still not optimized, make sure it is.
// assertOptimized(bar);

View File

@ -11,3 +11,12 @@ function foo() {
%OptimizeFunctionOnNextCall(foo); %OptimizeFunctionOnNextCall(foo);
assertEquals("fooed", foo()); assertEquals("fooed", foo());
assertOptimized(foo); assertOptimized(foo);
function bar() {
return "bared";
}
assertEquals("bared", bar());
%OptimizeFunctionOnNextCall(bar);
assertEquals("bared", bar());
assertOptimized(bar);