AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

Fix some random presubmit failures

Browse Source 
Change-Id: Ibd4c958875d777ba5241a6424ab23f8a2d0ac5ce
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3899263
Reviewed-by: Leszek Swirski <leszeks@chromium.org>
Commit-Queue: Dominik Inführ <dinfuehr@chromium.org>
Cr-Commit-Position: refs/heads/main@{#83256}
This commit is contained in:
Dominik Inführ 2022-09-16 12:01:45 +02:00 committed by V8 LUCI CQ
parent a3230428be
commit 79ac0de424
6 changed files with 5 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/snapshot/deserializer.h
View File

@ -245,7 +245,7 @@ class Deserializer : public SerializerDeserializer {
// be in an invalid state
class V8_NODISCARD DisableGCStats {
public:
explicit DisableGCStats() {
DisableGCStats() {
original_gc_stats_ = TracingFlags::gc_stats;
TracingFlags::gc_stats = 0;
}

2
test/unittests/assembler/disasm-arm-unittest.cc
View File

@ -1641,7 +1641,7 @@ static void TestLoadLiteral(byte* buffer, Assembler* assm, bool* failure,
}
TEST_F(DisasmArmTest,LoadLiteral) {
TEST_F(DisasmArmTest, LoadLiteral) {
SET_UP();
TestLoadLiteral(buffer, &assm, &failure, 0);

2
test/unittests/heap/global-safepoint-unittest.cc
View File

@ -22,7 +22,7 @@ namespace {
class IsolateWithContextWrapper {
public:
explicit IsolateWithContextWrapper()
IsolateWithContextWrapper()
: isolate_wrapper_(kNoCounters),
isolate_scope_(isolate_wrapper_.isolate()),
handle_scope_(isolate_wrapper_.isolate()),

1
test/unittests/heap/heap-utils.cc
View File

@ -13,7 +13,6 @@
#include "src/heap/new-spaces.h"
#include "src/heap/safepoint.h"
#include "src/objects/free-space-inl.h"
#include "v8-internal.h"
namespace v8 {
namespace internal {

1
test/unittests/heap/page-promotion-unittest.cc
View File

@ -4,7 +4,6 @@
#include "src/execution/isolate.h"
#include "test/unittests/heap/heap-utils.h"
#include "v8-isolate.h"
namespace v8 {
namespace internal {

5
test/unittests/interpreter/source-positions-unittest.cc
View File

@ -197,9 +197,8 @@ TEST_P(SourcePositionTest, SourcePositionsEquivalent) {
INSTANTIATE_TEST_SUITE_P(
SourcePositionsEquivalentTestCases, SourcePositionTest,
::testing::Combine(::testing::Values(kUseReo, kUseFilterExpressionPositions,
kUseReo | kUseFilterExpressionPositions
),
kUseReo |
kUseFilterExpressionPositions),
::testing::ValuesIn(kTestCaseData)));
} // namespace interpreter