AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[Interpreter] Fix test-log-stack-tracer for Ignition.

Browse Source 
BUG=v8:4680
LOG=N

Review URL: https://codereview.chromium.org/1692693004

Cr-Commit-Position: refs/heads/master@{#33930}
This commit is contained in:
rmcilroy 2016-02-12 00:48:44 -08:00 committed by Commit bot
parent 2cfa0e8906
commit 7a5b2339e7
2 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
test/cctest/cctest.status
View File

@ -581,10 +581,6 @@
'test-run-jsexceptions/ThrowMessagePosition': [FAIL],
'test-api/TryCatchMixedNesting': [PASS, FAIL],
# TODO(rmcilroy,4689): Stack frame calling frame is_javascript() failure.
'test-log-stack-tracer/CFromJSStackTrace': [FAIL],
'test-log-stack-tracer/PureJSStackTrace': [FAIL],
# TODO(rmcilroy,4680): Exception message assert failure.
'test-api/CallICFastApi_SimpleSignature_Miss2WithProfiler': [PASS, FAIL],
'test-api/InterceptorCallICFastApi_SimpleSignature_Miss3WithProfiler': [PASS, FAIL],

5
test/cctest/test-log-stack-tracer.cc
View File

@ -83,6 +83,11 @@ static void construct_call(const v8::FunctionCallbackInfo<v8::Value>& args) {
frame_iterator.Advance();
CHECK(frame_iterator.frame()->is_construct());
frame_iterator.Advance();
if (i::FLAG_ignition) {
// Skip over bytecode handler frame.
CHECK(frame_iterator.frame()->type() == i::StackFrame::STUB);
frame_iterator.Advance();
}
i::StackFrame* calling_frame = frame_iterator.frame();
CHECK(calling_frame->is_java_script());