From 7aac4791c0cf5fbc722f104fc72fbc8a27ef8bec Mon Sep 17 00:00:00 2001 From: Clemens Backes Date: Tue, 24 Jan 2023 14:20:34 +0100 Subject: [PATCH] [wasm-spec-tests] Document failed memory64 tests We currently skip a few memory64 spec tests; some for missing rebase, some for unknown reasons. It turns out that all of the failures are due to missing rebase on bulk memory or reference types. This CL documents that in the comment and removes a TODO. R=jkummerow@chromium.org CC=sbc@chromium.org Bug: v8:13692 Change-Id: I0ddf2bee0dcc36af5bc39251ed7b6b83d8de9aeb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4191771 Commit-Queue: Clemens Backes Reviewed-by: Jakob Kummerow Cr-Commit-Position: refs/heads/main@{#85457} --- test/wasm-spec-tests/wasm-spec-tests.status | 21 +++++++++++++++------ 1 file changed, 15 insertions(+), 6 deletions(-) diff --git a/test/wasm-spec-tests/wasm-spec-tests.status b/test/wasm-spec-tests/wasm-spec-tests.status index e2eeddf63d..2d1120817f 100644 --- a/test/wasm-spec-tests/wasm-spec-tests.status +++ b/test/wasm-spec-tests/wasm-spec-tests.status @@ -7,8 +7,23 @@ 'skip-stack-guard-page': [PASS, ['((arch == ppc or arch == ppc64 or arch == s390 or arch == s390x) and simulator_run)', SKIP]], # Missing rebase in the proposal repository. 'proposals/js-types/table': [FAIL], + # "data" is supposed to fail for "data segment does not fit"; missing rebase on + # https://github.com/WebAssembly/spec/commit/7fa2f20a. + 'proposals/memory64/data': [FAIL], + # "elem" is supposed to fail for "elements segment does not fit"; missing rebase on + # https://github.com/WebAssembly/spec/commit/7fa2f20a. + 'proposals/memory64/elem': [FAIL], + # "imports" is supposed to fail for "multiple tables"; missing rebase on + # https://github.com/WebAssembly/spec/commit/7fa2f20a. + 'proposals/memory64/imports': [FAIL], + # "linking" is supposed to fail for "elements segment does not fit"; missing rebase on + # https://github.com/WebAssembly/spec/commit/7fa2f20a. 'proposals/memory64/linking': [FAIL], + # "table" is supposed to fail for "multiple tables"; missing rebase on + # https://github.com/WebAssembly/spec/commit/7fa2f20a. 'proposals/memory64/table': [FAIL], + # "unreached-invalid" is supposed to fail for "type mismatch"; missing rebase on + # https://github.com/WebAssembly/spec/commit/7fa2f20a. 'proposals/memory64/unreached-invalid': [FAIL], # TODO(wasm): Roll newest tests into "js-types" repository. @@ -21,12 +36,6 @@ 'proposals/tail-call/globals': [FAIL], 'proposals/tail-call/linking': [FAIL], - # TODO(v8:11401): Fix memory64 spec tests / the v8 implementation (whatever - # is broken). - 'proposals/memory64/data': [FAIL], - 'proposals/memory64/elem': [FAIL], - 'proposals/memory64/imports': [FAIL], - # Tests that need to run sequentially (e.g. due to memory consumption). 'simd_f32x4*': [PASS, HEAVY], 'simd_f64x2*': [PASS, HEAVY],