AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[compiler] Remove unused JSFunctionData::function_data_

Browse Source 
Bug: v8:7790,v8:12149
Change-Id: I0c23b2c1126b2a950efe848973618407f64afeb7
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3132268
Auto-Submit: Jakob Gruber <jgruber@chromium.org>
Commit-Queue: Georg Neis <neis@chromium.org>
Reviewed-by: Georg Neis <neis@chromium.org>
Cr-Commit-Position: refs/heads/main@{#76601}
This commit is contained in:
Jakob Gruber 2021-08-31 13:34:12 +02:00 committed by V8 LUCI CQ
parent 494da13b05
commit 7b38608601
2 changed files with 0 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
src/compiler/heap-refs.cc
View File

@ -609,7 +609,6 @@ class JSFunctionData : public JSObjectData {
ObjectData* feedback_cell_ = nullptr;
int initial_map_instance_size_with_min_slack_; // Derives from
// prototype_or_initial_map_.
ObjectData* function_data_ = nullptr;
};
class BigIntData : public HeapObjectData {
@ -795,9 +794,6 @@ void JSFunctionData::Cache(JSHeapBroker* broker) {
SharedFunctionInfo shared = function->shared(kRelaxedLoad);
shared_ = broker->GetOrCreateData(shared, kAssumeMemoryFence);
function_data_ = broker->GetOrCreateData(shared.function_data(kAcquireLoad),
kAssumeMemoryFence);
if (function->has_prototype_slot()) {
prototype_or_initial_map_ = broker->GetOrCreateData(
function->prototype_or_initial_map(kAcquireLoad), kAssumeMemoryFence);
@ -866,13 +862,6 @@ bool JSFunctionData::IsConsistentWithHeapState(JSHeapBroker* broker) const {
CHECK_EQ(*native_context_->object(), f->native_context());
CHECK_EQ(*shared_->object(), f->shared());
if (*function_data_->object() !=
Handle<SharedFunctionInfo>::cast(shared_->object())
->function_data(kAcquireLoad)) {
TRACE_BROKER_MISSING(broker, "JSFunction::function_data");
return false;
}
if (f->has_prototype_slot()) {
if (*prototype_or_initial_map_->object() !=
f->prototype_or_initial_map(kAcquireLoad)) {

3
test/mjsunit/mjsunit.status
View File

@ -211,9 +211,6 @@
'regress/regress-crbug-941743': [PASS, HEAVY],
'regress/regress-crbug-1191886': [PASS, HEAVY],
'wasm/externref-globals': [PASS, HEAVY],
# TODO(v8:12149): Unskip once the JSFunctionRef dependency is relaxed.
'interrupt-budget-override': [SKIP],
}], # ALWAYS
##############################################################################