From 7b386394964f560af39d965acedc9b53bb4f8181 Mon Sep 17 00:00:00 2001 From: Jakob Gruber Date: Wed, 22 May 2019 14:46:08 +0200 Subject: [PATCH] [mksnapshot] Remove target OS defines These were added to support specific cross-compile scenarios that should now be covered by the --target-os and --target-arch flags. Bug: v8:9103 Change-Id: I848f4f39cecc83f9ec8529c4f8855662059e3dc5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1624219 Commit-Queue: Jakob Gruber Reviewed-by: Peter Marshall Cr-Commit-Position: refs/heads/master@{#61787} --- BUILD.gn | 8 -------- 1 file changed, 8 deletions(-) diff --git a/BUILD.gn b/BUILD.gn index 11524ba7c3..0cfa6a7356 100644 --- a/BUILD.gn +++ b/BUILD.gn @@ -3816,14 +3816,6 @@ if (v8_use_snapshot && current_toolchain == v8_snapshot_toolchain) { ":v8_nosnapshot", "//build/win:default_exe_manifest", ] - - if (target_os == "fuchsia") { - defines = [ "V8_TARGET_OS_FUCHSIA" ] - } else if (target_os == "win") { - defines = [ "V8_TARGET_OS_WIN" ] - } else if (target_os == "chromeos") { - defines = [ "V8_TARGET_OS_CHROMEOS" ] - } } }