AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[d8] Annotate global handles for realms

Browse Source 
Annotating the global handles gives us a nice description in heap
snapshots.

Bug: v8:12198
Change-Id: Ie6385794a6b5a1d43f5730b6ff521611f1b366af
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3304067
Reviewed-by: Camillo Bruni <cbruni@chromium.org>
Commit-Queue: Dominik Inführ <dinfuehr@chromium.org>
Cr-Commit-Position: refs/heads/main@{#78134}
This commit is contained in:
Dominik Inführ 2021-11-29 14:44:49 +01:00 committed by V8 LUCI CQ
parent 3bc5db7b7d
commit 7b85e666ee
1 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/d8/d8.cc
View File

@ -1724,6 +1724,7 @@ void Shell::RealmGlobal(const v8::FunctionCallbackInfo<v8::Value>& args) {
MaybeLocal<Context> Shell::CreateRealm(
const v8::FunctionCallbackInfo<v8::Value>& args, int index,
v8::MaybeLocal<Value> global_object) {
const char* kGlobalHandleLabel = "d8::realm";
Isolate* isolate = args.GetIsolate();
TryCatch try_catch(isolate);
PerIsolateData* data = PerIsolateData::Get(isolate);
@ -1732,7 +1733,11 @@ MaybeLocal<Context> Shell::CreateRealm(
index = data->realm_count_;
data->realms_ = new Global<Context>[++data->realm_count_];
for (int i = 0; i < index; ++i) {
data->realms_[i].Reset(isolate, old_realms[i]);
Global<Context>& realm = data->realms_[i];
realm.Reset(isolate, old_realms[i]);
if (!realm.IsEmpty()) {
realm.AnnotateStrongRetainer(kGlobalHandleLabel);
}
old_realms[i].Reset();
}
delete[] old_realms;
@ -1744,6 +1749,7 @@ MaybeLocal<Context> Shell::CreateRealm(
if (context.IsEmpty()) return MaybeLocal<Context>();
InitializeModuleEmbedderData(context);
data->realms_[index].Reset(isolate, context);
data->realms_[index].AnnotateStrongRetainer(kGlobalHandleLabel);
args.GetReturnValue().Set(index);
return context;
}