AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

Don't even include v8.h from libbase or libplatform

Browse Source 
BUG=none
R=yangguo@chromium.org
LOG=n

Review URL: https://codereview.chromium.org/369073002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22182 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
This commit is contained in:
jochen@chromium.org 2014-07-03 08:50:52 +00:00
parent abb0ff205c
commit 7b94143287
7 changed files with 18 additions and 23 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
BUILD.gn
View File

@ -37,6 +37,12 @@ config("internal_config") {
}
}
config("internal_config_base") {
visibility = ":*" # Only targets in this file can depend on this.
include_dirs = [ "." ]
}
# This config should only be applied to code using V8 and not any V8 code
# itself.
config("external_config") {
@ -1014,7 +1020,7 @@ source_set("v8_libbase") {
configs -= [ "//build/config/compiler:chromium_code" ]
configs += [ "//build/config/compiler:no_chromium_code" ]
configs += [ ":internal_config", ":features", ":toolchain" ]
configs += [ ":internal_config_base", ":features", ":toolchain" ]
defines = []
@ -1077,7 +1083,7 @@ source_set("v8_libplatform") {
configs -= [ "//build/config/compiler:chromium_code" ]
configs += [ "//build/config/compiler:no_chromium_code" ]
configs += [ ":internal_config", ":features", ":toolchain" ]
configs += [ ":internal_config_base", ":features", ":toolchain" ]
deps = [
":v8_libbase",

4
include/v8-platform.h
View File

@ -5,10 +5,10 @@
#ifndef V8_V8_PLATFORM_H_
#define V8_V8_PLATFORM_H_
#include "v8.h"
namespace v8 {
class Isolate;
/**
* A Task represents a unit of work.
*/

3
src/base/DEPS
View File

@ -1,4 +1,7 @@
include_rules = [
"-include",
"+include/v8config.h",
"+include/v8stdint.h",
"-src",
"+src/base",
]

2
src/base/atomicops.h
View File

@ -25,7 +25,7 @@
#ifndef V8_BASE_ATOMICOPS_H_
#define V8_BASE_ATOMICOPS_H_
#include "include/v8.h"
#include "include/v8stdint.h"
#include "src/base/build_config.h"
#if defined(_WIN32) && defined(V8_HOST_ARCH_64_BIT)

3
src/libplatform/DEPS
View File

@ -1,4 +1,7 @@
include_rules = [
"-include",
"+include/libplatform",
"+include/v8-platform.h",
"-src",
"+src/base",
"+src/libplatform",

1
src/utils.h
View File

@ -9,6 +9,7 @@
#include <stdlib.h>
#include <string.h>
#include "include/v8.h"
#include "src/allocation.h"
#include "src/base/logging.h"
#include "src/base/macros.h"

18
tools/gyp/v8.gyp
View File

@ -996,12 +996,6 @@
}, {
'toolsets': ['target'],
}],
['component=="shared_library"', {
'defines': [
'BUILDING_V8_SHARED',
'V8_SHARED',
],
}],
['OS=="linux"', {
'link_settings': {
'libraries': [
@ -1193,12 +1187,6 @@
}],
],
}],
['component=="shared_library"', {
'defines': [
'BUILDING_V8_SHARED',
'V8_SHARED',
],
}],
],
},
{
@ -1228,12 +1216,6 @@
}, {
'toolsets': ['target'],
}],
['component=="shared_library"', {
'defines': [
'BUILDING_V8_SHARED',
'V8_SHARED',
],
}],
],
},
{