AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

Turn on icu_case_mapping by default

Browse Source 
BUG=v8:4477, v8:4476
TEST=test262/{built-ins,intl402}/Strings/*, webkit/fast/js/*,
     mjsunit/string-case, intl/general/case*

Review-Url: https://codereview.chromium.org/2588963002
Cr-Commit-Position: refs/heads/master@{#41834}
This commit is contained in:
jshin 2016-12-20 01:00:50 -08:00 committed by Commit bot
parent 0a5bffe24d
commit 7c79e23c34
2 changed files with 14 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
src/flag-definitions.h
View File

@ -214,16 +214,23 @@ DEFINE_IMPLICATION(es_staging, move_object_start)
V(harmony_string_padding, "harmony String-padding methods")
#ifdef V8_I18N_SUPPORT
#define HARMONY_STAGED(V) \
HARMONY_STAGED_BASE(V) \
V(datetime_format_to_parts, "Intl.DateTimeFormat.formatToParts") \
V(icu_case_mapping, "case mapping with ICU rather than Unibrow")
#define HARMONY_STAGED(V) \
HARMONY_STAGED_BASE(V) \
V(datetime_format_to_parts, "Intl.DateTimeFormat.formatToParts")
#else
#define HARMONY_STAGED(V) HARMONY_STAGED_BASE(V)
#endif
// Features that are shipping (turned on by default, but internal flag remains).
#define HARMONY_SHIPPING(V) V(harmony_async_await, "harmony async-await")
#define HARMONY_SHIPPING_BASE(V) V(harmony_async_await, "harmony async-await")
#ifdef V8_I18N_SUPPORT
#define HARMONY_SHIPPING(V) \
HARMONY_SHIPPING_BASE(V) \
V(icu_case_mapping, "case mapping with ICU rather than Unibrow")
#else
#define HARMONY_SHIPPING(V) HARMONY_SHIPPING_BASE(V)
#endif
// Once a shipping feature has proved stable in the wild, it will be dropped
// from HARMONY_SHIPPING, all occurrences of the FLAG_ variable are removed,

4
test/webkit/fast/js/string-capitalization-expected.txt
View File

@ -26,8 +26,8 @@ This test checks that toLowerCase and toUpperCase handle certain non-trivial cas
On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
FAIL String("A𐐀").toLowerCase() should be a𐐨. Was a𐐀.
FAIL String("a𐐨").toUpperCase() should be A𐐀. Was A𐐨.
PASS String("A𐐀").toLowerCase() is "a𐐨"
PASS String("a𐐨").toUpperCase() is "A𐐀"
PASS String("ΚΟΣΜΟΣ ΚΟΣΜΟΣ").toLowerCase() is "κοσμος κοσμος"
PASS String("ß").toUpperCase() is "SS"
PASS String("ʼn").toUpperCase() is "ʼN"