AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

Revert "[ptr-compr][CSA] Enable the DecompressionOptimizer phase in CSA"

Browse Source 
This reverts commit ad9bd3a0cc.

Reason for revert: Speculative revert for TSAN failures (https://ci.chromium.org/p/v8/builders/ci/V8%20Linux64%20TSAN/28816)

Original change's description:
> [ptr-compr][CSA] Enable the DecompressionOptimizer phase in CSA
> 
> Also update the MachineGraphVerifier to take into account the
> possibility of the Store receiving a Compressed representation as well.
> 
> Bug: v8:7703
> Change-Id: I6d6e28b980151af6296000cfe6f67a3a037b029c
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1859627
> Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org>
> Reviewed-by: Tobias Tebbi <tebbi@chromium.org>
> Reviewed-by: Jakob Gruber <jgruber@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#64410}

TBR=jgruber@chromium.org,tebbi@chromium.org,solanes@chromium.org

Change-Id: I805593d9b49503a20348a4b059049ed24345cf8e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: v8:7703
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1871914
Reviewed-by: Leszek Swirski <leszeks@chromium.org>
Commit-Queue: Leszek Swirski <leszeks@chromium.org>
Cr-Commit-Position: refs/heads/master@{#64415}
This commit is contained in:
Leszek Swirski 2019-10-21 11:38:18 +00:00 committed by Commit Bot
parent 12e1cfcd22
commit 7cb5925154
2 changed files with 1 additions and 34 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

31
src/compiler/machine-graph-verifier.cc
View File

@ -617,15 +617,7 @@ class MachineRepresentationChecker {
case MachineRepresentation::kTagged:
case MachineRepresentation::kTaggedPointer:
case MachineRepresentation::kTaggedSigned:
if (COMPRESS_POINTERS_BOOL &&
!FLAG_turbo_decompression_elimination &&
node->opcode() == IrOpcode::kStore &&
CanBeTaggedPointer(
StoreRepresentationOf(node->op()).representation())) {
CheckValueInputIsCompressedOrTagged(node, 2);
} else {
CheckValueInputIsTagged(node, 2);
}
CheckValueInputIsTagged(node, 2);
break;
case MachineRepresentation::kCompressed:
case MachineRepresentation::kCompressedPointer:
@ -807,27 +799,6 @@ class MachineRepresentationChecker {
FATAL("%s", str.str().c_str());
}
void CheckValueInputIsCompressedOrTagged(Node const* node, int index) {
Node const* input = node->InputAt(index);
switch (inferrer_->GetRepresentation(input)) {
case MachineRepresentation::kCompressed:
case MachineRepresentation::kCompressedPointer:
case MachineRepresentation::kCompressedSigned:
case MachineRepresentation::kTagged:
case MachineRepresentation::kTaggedPointer:
case MachineRepresentation::kTaggedSigned:
return;
default:
break;
}
std::ostringstream str;
str << "TypeError: node #" << node->id() << ":" << *node->op()
<< " uses node #" << input->id() << ":" << *input->op()
<< " which doesn't have a compressed or tagged representation.";
PrintDebugHelp(str, node);
FATAL("%s", str.str().c_str());
}
void CheckValueInputIsTaggedOrPointer(Node const* node, int index) {
Node const* input = node->InputAt(index);
switch (inferrer_->GetRepresentation(input)) {

4
src/compiler/pipeline.cc
View File

@ -2571,10 +2571,6 @@ MaybeHandle<Code> Pipeline::GenerateCodeForCodeStub(
pipeline.Run<CsaOptimizationPhase>();
pipeline.RunPrintAndVerify(CsaOptimizationPhase::phase_name(), true);
pipeline.Run<DecompressionOptimizationPhase>();
pipeline.RunPrintAndVerify(DecompressionOptimizationPhase::phase_name(),
true);
pipeline.Run<VerifyGraphPhase>(true);
pipeline.ComputeScheduledGraph();
DCHECK_NOT_NULL(data.schedule());