AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[wasm][debug] Recompile Liftoff code on isolate removal

Browse Source 
This fixes a check in the code that recompiles Liftoff
if breakpoints were removed on isolate removal.

Change-Id: I969b1b027a393f48e92ef4df37f6e672d16866cc
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2247648
Reviewed-by: Clemens Backes <clemensb@chromium.org>
Commit-Queue: Kim-Anh Tran <kimanh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#68386}
This commit is contained in:
Kim-Anh Tran 2020-06-16 14:07:00 +02:00 committed by Commit Bot
parent ee9a704b20
commit 7ccb7175b4
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/wasm/wasm-debug.cc
View File

@ -633,8 +633,10 @@ class DebugInfoImpl {
base::MutexGuard guard(&mutex_);
auto per_isolate_data_it = per_isolate_data_.find(isolate);
if (per_isolate_data_it == per_isolate_data_.end()) return;
std::unordered_map<int, std::vector<int>> removed_per_function;
for (auto& entry : per_isolate_data_it->second.breakpoints_per_function) {
std::unordered_map<int, std::vector<int>> removed_per_function =
std::move(per_isolate_data_it->second.breakpoints_per_function);
per_isolate_data_.erase(per_isolate_data_it);
for (auto& entry : removed_per_function) {
int func_index = entry.first;
std::vector<int>& removed = entry.second;
std::vector<int> remaining = FindAllBreakpoints(func_index);
@ -642,7 +644,6 @@ class DebugInfoImpl {
RecompileLiftoffWithBreakpoints(func_index, VectorOf(remaining), {});
}
}
per_isolate_data_.erase(per_isolate_data_it);
}
private: