From 7d714b61b49623529abfd7bcae4ee3b2c95c33de Mon Sep 17 00:00:00 2001 From: Clemens Hammacher Date: Fri, 5 Apr 2019 10:37:19 +0000 Subject: [PATCH] Revert "[regalloc] Enable control flow aware allocation" This reverts commit 1fb26d837fb9999003d3947b49bc6f107e6ceef4. Reason for revert: Flushes out TSan issues: https://ci.chromium.org/p/v8/builders/ci/V8%20Linux64%20TSAN/25782 Original change's description: > [regalloc] Enable control flow aware allocation > > This is a test to see how much and where we regress. We have seen > some quirks of our current allocator that do not show up in this > new approach, so we need to decide whether to stabilize the new > allocation scheme. Performance numbers are a key indicator for that > decision. > > This patch is intended to be reverted after stability and performance > numbers are in (i.e. after a few days). > > Change-Id: I8df8ff7de8efa82a8abbdfa1d21d7877756f129e > Bug: v8:9088 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1552786 > Reviewed-by: Michael Starzinger > Reviewed-by: Jaroslav Sevcik > Commit-Queue: Sigurd Schneider > Cr-Commit-Position: refs/heads/master@{#60643} TBR=mstarzinger@chromium.org,jarin@chromium.org,sigurds@chromium.org Change-Id: Ia1934b01b0909479b2bd52ba686cc9b3fb364b4b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:9088 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1554682 Reviewed-by: Clemens Hammacher Commit-Queue: Clemens Hammacher Cr-Commit-Position: refs/heads/master@{#60645} --- src/flag-definitions.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/flag-definitions.h b/src/flag-definitions.h index 9999e84b49..d61995e052 100644 --- a/src/flag-definitions.h +++ b/src/flag-definitions.h @@ -440,9 +440,9 @@ DEFINE_BOOL(print_deopt_stress, false, "print number of possible deopt points") // Flags for TurboFan. DEFINE_BOOL(turbo_sp_frame_access, false, "use stack pointer-relative access to frame wherever possible") -DEFINE_BOOL(turbo_preprocess_ranges, false, +DEFINE_BOOL(turbo_preprocess_ranges, true, "run pre-register allocation heuristics") -DEFINE_BOOL(turbo_control_flow_aware_allocation, true, +DEFINE_BOOL(turbo_control_flow_aware_allocation, false, "consider control flow while allocating registers") DEFINE_NEG_IMPLICATION(turbo_control_flow_aware_allocation, turbo_preprocess_ranges)