From 7e61eb337f48cc44b994b6c8c292f27d4a13d68b Mon Sep 17 00:00:00 2001 From: Ulan Degenbaev Date: Thu, 19 Apr 2018 15:13:40 +0200 Subject: [PATCH] [test] Make test-api/ScavengeExternal*String non-threaded test. ScavengeExternalString and ScavengeExternalOneByteString clear GC flags, which confuses concurrent sweeping that was started from another test. Tests that mutate flags should not be threaded. Bug: v8:7671 Change-Id: I08656d06fe85ff45baca685ebe5982528aad774c Reviewed-on: https://chromium-review.googlesource.com/1019102 Reviewed-by: Peter Marshall Commit-Queue: Ulan Degenbaev Cr-Commit-Position: refs/heads/master@{#52690} --- test/cctest/test-api.cc | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/test/cctest/test-api.cc b/test/cctest/test-api.cc index 62eed9455a..756fe4f3d2 100644 --- a/test/cctest/test-api.cc +++ b/test/cctest/test-api.cc @@ -786,8 +786,7 @@ THREADED_TEST(NewExternalForVeryLongString) { } } - -THREADED_TEST(ScavengeExternalString) { +TEST(ScavengeExternalString) { ManualGCScope manual_gc_scope; i::FLAG_stress_compaction = false; i::FLAG_gc_global = false; @@ -811,8 +810,7 @@ THREADED_TEST(ScavengeExternalString) { CHECK_EQ(1, dispose_count); } - -THREADED_TEST(ScavengeExternalOneByteString) { +TEST(ScavengeExternalOneByteString) { ManualGCScope manual_gc_scope; i::FLAG_stress_compaction = false; i::FLAG_gc_global = false;