AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[offthread] Disable compiler dispatcher tests

Browse Source 
Disable the BackgroundCompileTask and CompilerDispatcher unittests when
--finalize-streaming-on-background is enabled. The inner function API to
concurrent compilation doesn't yet support off-thread finalization, so
these tests break under that configuration.

Bug: chromium:1011762
Change-Id: If8d8d8e814161668e12f309e8d69ef8e8a29ab4a
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2502329
Commit-Queue: Ross McIlroy <rmcilroy@chromium.org>
Reviewed-by: Ross McIlroy <rmcilroy@chromium.org>
Auto-Submit: Leszek Swirski <leszeks@chromium.org>
Cr-Commit-Position: refs/heads/master@{#70846}
This commit is contained in:
Leszek Swirski 2020-10-28 12:57:45 +01:00 committed by Commit Bot
parent b16c7e5b1c
commit 7f2d66cd98
2 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
test/unittests/compiler-dispatcher/compiler-dispatcher-unittest.cc
View File

@ -33,6 +33,8 @@ class CompilerDispatcherTestFlags {
CHECK_NULL(save_flags_);
save_flags_ = new SaveFlags();
FLAG_single_threaded = true;
// TODO(leszeks): Support background finalization in compiler dispatcher.
FLAG_finalize_streaming_on_background = false;
FlagList::EnforceFlagImplications();
FLAG_compiler_dispatcher = true;
}

2
test/unittests/tasks/background-compile-task-unittest.cc
View File

@ -35,6 +35,8 @@ class BackgroundCompileTaskTest : public TestWithNativeContext {
static void SetUpTestCase() {
CHECK_NULL(save_flags_);
save_flags_ = new SaveFlags();
// TODO(leszeks): Support background finalization in compiler dispatcher.
FLAG_finalize_streaming_on_background = false;
TestWithNativeContext::SetUpTestCase();
}