AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[string] DCHECK instead of test that ThinString's actuals have same length

Browse Source 
ThinStrings always forward to internalized strings that have the same
character contents and thus the same length.

Change-Id: I5929d266f96b23029f4786baf993a431cf4ad38d
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3541522
Reviewed-by: Leszek Swirski <leszeks@chromium.org>
Commit-Queue: Shu-yu Guo <syg@chromium.org>
Cr-Commit-Position: refs/heads/main@{#79582}
This commit is contained in:
Shu-yu Guo 2022-03-21 18:04:08 -07:00 committed by V8 LUCI CQ
parent ffae028b37
commit 802c7b3e16
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/objects/string-table.cc
View File

@ -719,9 +719,8 @@ Address StringTable::TryStringToIndexOrLookupExisting(Isolate* isolate,
}
if (source.IsThinString()) {
source = ThinString::cast(source).actual();
if (string.length() == source.length()) {
return source.ptr();
}
DCHECK_EQ(string.length(), source.length());
return source.ptr();
}
if (source.IsOneByteRepresentation()) {