AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

Run all message tests with a variant that forces preparsing

Browse Source 
This will make sure that message tests cover both the parser and preparser
paths, just as we do for parsing-related cctests.

BUG=v8:4372
LOG=n

Review URL: https://codereview.chromium.org/1469383004

Cr-Commit-Position: refs/heads/master@{#32307}
This commit is contained in:
adamk 2015-11-25 13:02:08 -08:00 committed by Commit bot
parent 481bad1ff0
commit 802ea71e7c
2 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
test/message/testcfg.py
View File

@ -59,6 +59,10 @@ class MessageTestSuite(testsuite.TestSuite):
tests.append(test) tests.append(test)
return tests return tests
def CreateVariantGenerator(self, variants):
return super(MessageTestSuite, self).CreateVariantGenerator(
variants + ["preparser"])
def GetFlagsForTestCase(self, testcase, context): def GetFlagsForTestCase(self, testcase, context):
source = self.GetSourceForTest(testcase) source = self.GetSourceForTest(testcase)
result = [] result = []

4
tools/testrunner/local/testsuite.py
View File

@ -44,6 +44,7 @@ ALL_VARIANT_FLAGS = {
"ignition": [["--ignition", "--ignition-filter=*", "ignition": [["--ignition", "--ignition-filter=*",
"--ignition-fake-try-catch", "--ignition-fake-try-catch",
"--ignition-fallback-on-eval-and-catch"]], "--ignition-fallback-on-eval-and-catch"]],
"preparser": [["--min-preparse-length=0"]],
} }
# FAST_VARIANTS implies no --always-opt. # FAST_VARIANTS implies no --always-opt.
@ -55,10 +56,11 @@ FAST_VARIANT_FLAGS = {
"ignition": [["--ignition", "--ignition-filter=*", "ignition": [["--ignition", "--ignition-filter=*",
"--ignition-fake-try-catch", "--ignition-fake-try-catch",
"--ignition-fallback-on-eval-and-catch"]], "--ignition-fallback-on-eval-and-catch"]],
"preparser": [["--min-preparse-length=0"]],
} }
ALL_VARIANTS = set(["default", "stress", "turbofan", "turbofan_opt", ALL_VARIANTS = set(["default", "stress", "turbofan", "turbofan_opt",
"nocrankshaft", "ignition"]) "nocrankshaft", "ignition", "preparser"])
FAST_VARIANTS = set(["default", "turbofan"]) FAST_VARIANTS = set(["default", "turbofan"])
STANDARD_VARIANT = set(["default"]) STANDARD_VARIANT = set(["default"])