AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[profiler][etw] Do not enable --interpreted-frames-native-stack with ETW events

Browse Source 
When ETW Events are enabled with the --enable-etw-stack-walking flag
we should not also enable the --interpreted-frames-native-stack by
default.
Showing the interpreted frames on the native stack is quite expensive
since it involves mulltiple copies of the interpreter trampolines, and
it's not always necessary to profile JS code, so it should be enabled
when necessary with a separate flag.

Bug: v8:11043
Change-Id: Id2d779e7fcac9b626f9da2e0c77edf9c30f853df
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3893601
Commit-Queue: Paolo Severini <paolosev@microsoft.com>
Reviewed-by: Camillo Bruni <cbruni@chromium.org>
Cr-Commit-Position: refs/heads/main@{#83229}
This commit is contained in:
Paolo Severini 2022-09-13 10:29:58 -07:00 committed by V8 LUCI CQ
parent 588688f336
commit 8199d70fd6
1 changed files with 0 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/flags/flag-definitions.h
View File

@ -2217,9 +2217,6 @@ DEFINE_BOOL(enable_etw_stack_walking, false,
"Enable etw stack walking for windows")
// Don't move code objects.
DEFINE_NEG_IMPLICATION(enable_etw_stack_walking, compact_code_space)
#ifndef V8_TARGET_ARCH_ARM
DEFINE_IMPLICATION(enable_etw_stack_walking, interpreted_frames_native_stack)
#endif
//
// Disassembler only flags