AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

Fix HTML string methods to not depend on replace method

Browse Source 
Before this we were using String.prototype.replace. Now
we call the internal StringReplace instead.

BUG=v8:4221
LOG=N
R=adamk, littledan
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.blink:linux_blink_rel

Review URL: https://codereview.chromium.org/1199933005

Cr-Commit-Position: refs/heads/master@{#29206}
This commit is contained in:
arv 2015-06-22 14:55:41 -07:00 committed by Commit bot
parent 1c575e917a
commit 81f2c44047
2 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/string.js
View File

@ -846,7 +846,7 @@ function StringFromCharCode(code) {
// ES6 draft, revision 26 (2014-07-18), section B.2.3.2.1
function HtmlEscape(str) {
return TO_STRING_INLINE(str).replace(/"/g, """);
return %_CallFunction(TO_STRING_INLINE(str), /"/g, """, StringReplace);
}

7
test/mjsunit/es6/string-html.js
View File

@ -192,3 +192,10 @@ assertEquals(String.prototype.sup.length, 0);
assertEquals(1, calls);
}
})();
(function TestDeleteStringRelace() {
assertEquals('<a name="n">s</a>', 's'.anchor('n'));
assertTrue(delete String.prototype.replace);
assertEquals('<a name="n">s</a>', 's'.anchor('n'));
})();