AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[heap] Make OutOfMemoryIneffectiveGC test more robust.

Browse Source 
The checked condition now more precisely corresponds to the actual
ineffective GC detection heuristic.

Change-Id: I727932c76ff3183e7b038437eefba564c9778ff7
Reviewed-on: https://chromium-review.googlesource.com/997634
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Reviewed-by: Hannes Payer <hpayer@chromium.org>
Commit-Queue: Ulan Degenbaev <ulan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#52509}
This commit is contained in:
Ulan Degenbaev 2018-04-05 12:49:38 +02:00 committed by Commit Bot
parent 75e04cd22c
commit 81fa51c06f
1 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
test/cctest/heap/test-heap.cc
View File

@ -5923,11 +5923,18 @@ UNINITIALIZED_TEST(OutOfMemoryIneffectiveGC) {
} }
{ {
int initial_ms_count = heap->ms_count(); int initial_ms_count = heap->ms_count();
int ineffective_ms_start = initial_ms_count;
while (heap->ms_count() < initial_ms_count + 10) { while (heap->ms_count() < initial_ms_count + 10) {
HandleScope inner_scope(i_isolate); HandleScope inner_scope(i_isolate);
factory->NewFixedArray(30000, TENURED); factory->NewFixedArray(30000, TENURED);
if (heap->tracer()->CurrentMarkCompactMutatorUtilization() >= 0.3) {
ineffective_ms_start = heap->ms_count() + 1;
} }
CHECK_GE(heap->tracer()->AverageMarkCompactMutatorUtilization(), 0.09); }
int consecutive_ineffective_ms = heap->ms_count() - ineffective_ms_start;
CHECK_IMPLIES(
consecutive_ineffective_ms >= 4,
heap->tracer()->AverageMarkCompactMutatorUtilization() >= 0.3);
} }
} }
isolate->Dispose(); isolate->Dispose();