AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[wasm] Fix allocation of win64 crashpad data

Browse Source 
Ensure that the "padding" (actually needed for crashpad) is allocated
at the beginning of the new code space.

R=ahaas@chromium.org

Bug: v8:9477
Change-Id: I44b9e9feb559788e286fd5c57df90db7cf7f5340
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1803650
Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
Reviewed-by: Andreas Haas <ahaas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#63790}
This commit is contained in:
Clemens Hammacher 2019-09-16 13:09:07 +02:00 committed by Commit Bot
parent 2f9d2fc1ce
commit 82176ac3f5
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/wasm/wasm-code-manager.cc
View File

@ -1199,9 +1199,9 @@ void NativeModule::AddCodeSpace(base::AddressRegion region) {
!implicit_alloc_disabled) {
size_t size = Heap::GetCodeRangeReservedAreaSize();
DCHECK_LT(0, size);
Vector<byte> padding = code_allocator_.AllocateForCode(this, size);
CHECK(region.contains(reinterpret_cast<Address>(padding.begin()),
padding.size()));
Vector<byte> padding =
code_allocator_.AllocateForCodeInRegion(this, size, region);
CHECK_EQ(reinterpret_cast<Address>(padding.begin()), region.begin());
}
#endif // V8_OS_WIN64