AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[flags] Remove --harmony-array-find-last

Browse Source 
The Array and TypedArray findLast and findLastIndex proposal has shipped
since M97.

Bug: v8:11990
Change-Id: Iece995c020c2b5535abc4dd2a47516265e445fc3
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4144631
Commit-Queue: Shu-yu Guo <syg@chromium.org>
Reviewed-by: Adam Klein <adamk@chromium.org>
Auto-Submit: Shu-yu Guo <syg@chromium.org>
Cr-Commit-Position: refs/heads/main@{#85235}
This commit is contained in:
Shu-yu Guo 2023-01-10 13:11:39 -08:00 committed by V8 LUCI CQ
parent a216b3de4b
commit 8267c7e12c
3 changed files with 74 additions and 98 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/flags/flag-definitions.h
View File

@ -257,7 +257,6 @@ DEFINE_IMPLICATION(harmony_rab_gsab_transfer, harmony_rab_gsab)
V(harmony_sharedarraybuffer, "harmony sharedarraybuffer") \
V(harmony_atomics, "harmony atomics") \
V(harmony_class_static_blocks, "harmony static initializer blocks") \
V(harmony_array_find_last, "harmony array find last helpers") \
V(harmony_import_assertions, "harmony import assertions") \
V(harmony_symbol_as_weakmap_key, "harmony symbols as weakmap keys") \
V(harmony_change_array_by_copy, "harmony change-Array-by-copy")

43
src/init/bootstrapper.cc
View File

@ -1801,6 +1801,10 @@ void Genesis::InitializeGlobal(Handle<JSGlobalObject> global_object,
1, false);
SimpleInstallFunction(isolate_, proto, "findIndex",
Builtin::kArrayPrototypeFindIndex, 1, false);
SimpleInstallFunction(isolate_, proto, "findLast",
Builtin::kArrayPrototypeFindLast, 1, false);
SimpleInstallFunction(isolate_, proto, "findLastIndex",
Builtin::kArrayPrototypeFindLastIndex, 1, false);
SimpleInstallFunction(isolate_, proto, "lastIndexOf",
Builtin::kArrayPrototypeLastIndexOf, 1, false);
SimpleInstallFunction(isolate_, proto, "pop", Builtin::kArrayPrototypePop,
@ -1873,6 +1877,8 @@ void Genesis::InitializeGlobal(Handle<JSGlobalObject> global_object,
InstallTrueValuedProperty(isolate_, unscopables, "fill");
InstallTrueValuedProperty(isolate_, unscopables, "find");
InstallTrueValuedProperty(isolate_, unscopables, "findIndex");
InstallTrueValuedProperty(isolate_, unscopables, "findLast");
InstallTrueValuedProperty(isolate_, unscopables, "findLastIndex");
InstallTrueValuedProperty(isolate_, unscopables, "flat");
InstallTrueValuedProperty(isolate_, unscopables, "flatMap");
InstallTrueValuedProperty(isolate_, unscopables, "includes");
@ -3393,6 +3399,10 @@ void Genesis::InitializeGlobal(Handle<JSGlobalObject> global_object,
Builtin::kTypedArrayPrototypeFind, 1, false);
SimpleInstallFunction(isolate_, prototype, "findIndex",
Builtin::kTypedArrayPrototypeFindIndex, 1, false);
SimpleInstallFunction(isolate_, prototype, "findLast",
Builtin::kTypedArrayPrototypeFindLast, 1, false);
SimpleInstallFunction(isolate_, prototype, "findLastIndex",
Builtin::kTypedArrayPrototypeFindLastIndex, 1, false);
SimpleInstallFunction(isolate_, prototype, "forEach",
Builtin::kTypedArrayPrototypeForEach, 1, false);
SimpleInstallFunction(isolate_, prototype, "includes",
@ -4755,39 +4765,6 @@ void Genesis::InitializeGlobal_harmony_struct() {
}
}
void Genesis::InitializeGlobal_harmony_array_find_last() {
if (!v8_flags.harmony_array_find_last) return;
{
Handle<JSFunction> array_function(native_context()->array_function(),
isolate());
Handle<JSObject> array_prototype(
JSObject::cast(array_function->instance_prototype()), isolate());
SimpleInstallFunction(isolate_, array_prototype, "findLast",
Builtin::kArrayPrototypeFindLast, 1, false);
SimpleInstallFunction(isolate_, array_prototype, "findLastIndex",
Builtin::kArrayPrototypeFindLastIndex, 1, false);
Handle<JSObject> unscopables = Handle<JSObject>::cast(
JSObject::GetProperty(isolate(), array_prototype,
isolate()->factory()->unscopables_symbol())
.ToHandleChecked());
InstallTrueValuedProperty(isolate_, unscopables, "findLast");
InstallTrueValuedProperty(isolate_, unscopables, "findLastIndex");
}
{
Handle<JSObject> prototype(native_context()->typed_array_prototype(),
isolate());
SimpleInstallFunction(isolate_, prototype, "findLast",
Builtin::kTypedArrayPrototypeFindLast, 1, false);
SimpleInstallFunction(isolate_, prototype, "findLastIndex",
Builtin::kTypedArrayPrototypeFindLastIndex, 1, false);
}
}
void Genesis::InitializeGlobal_harmony_array_grouping() {
if (!v8_flags.harmony_array_grouping) return;

128
tools/v8heapconst.py
View File

@ -481,8 +481,8 @@ KNOWN_MAPS = {
("read_only_space", 0x03e95): (272, "WasmTypeInfoMap"),
("read_only_space", 0x03ebd): (268, "WasmContinuationObjectMap"),
("read_only_space", 0x03ee5): (274, "WeakCellMap"),
("old_space", 0x0438d): (2114, "ExternalMap"),
("old_space", 0x043b5): (2118, "JSMessageObjectMap"),
("old_space", 0x043bd): (2114, "ExternalMap"),
("old_space", 0x043e5): (2118, "JSMessageObjectMap"),
}
# List of known V8 objects.
@ -539,68 +539,68 @@ KNOWN_OBJECTS = {
("read_only_space", 0x082ed): "NativeScopeInfo",
("read_only_space", 0x08305): "ShadowRealmScopeInfo",
("read_only_space", 0x0831d): "OffHeapTrampolineRelocationInfo",
("old_space", 0x0423d): "ArgumentsIteratorAccessor",
("old_space", 0x04255): "ArrayLengthAccessor",
("old_space", 0x0426d): "BoundFunctionLengthAccessor",
("old_space", 0x04285): "BoundFunctionNameAccessor",
("old_space", 0x0429d): "ErrorStackAccessor",
("old_space", 0x042b5): "FunctionArgumentsAccessor",
("old_space", 0x042cd): "FunctionCallerAccessor",
("old_space", 0x042e5): "FunctionNameAccessor",
("old_space", 0x042fd): "FunctionLengthAccessor",
("old_space", 0x04315): "FunctionPrototypeAccessor",
("old_space", 0x0432d): "StringLengthAccessor",
("old_space", 0x04345): "ValueUnavailableAccessor",
("old_space", 0x0435d): "WrappedFunctionLengthAccessor",
("old_space", 0x04375): "WrappedFunctionNameAccessor",
("old_space", 0x0438d): "ExternalMap",
("old_space", 0x043b5): "JSMessageObjectMap",
("old_space", 0x043dd): "EmptyScript",
("old_space", 0x04421): "ManyClosuresCell",
("old_space", 0x0442d): "ArrayConstructorProtector",
("old_space", 0x04441): "NoElementsProtector",
("old_space", 0x04455): "MegaDOMProtector",
("old_space", 0x04469): "IsConcatSpreadableProtector",
("old_space", 0x0447d): "ArraySpeciesProtector",
("old_space", 0x04491): "TypedArraySpeciesProtector",
("old_space", 0x044a5): "PromiseSpeciesProtector",
("old_space", 0x044b9): "RegExpSpeciesProtector",
("old_space", 0x044cd): "StringLengthProtector",
("old_space", 0x044e1): "ArrayIteratorProtector",
("old_space", 0x044f5): "ArrayBufferDetachingProtector",
("old_space", 0x04509): "PromiseHookProtector",
("old_space", 0x0451d): "PromiseResolveProtector",
("old_space", 0x04531): "MapIteratorProtector",
("old_space", 0x04545): "PromiseThenProtector",
("old_space", 0x04559): "SetIteratorProtector",
("old_space", 0x0456d): "StringIteratorProtector",
("old_space", 0x04581): "StringSplitCache",
("old_space", 0x04989): "RegExpMultipleCache",
("old_space", 0x04d91): "BuiltinsConstantsTable",
("old_space", 0x05361): "AsyncFunctionAwaitRejectSharedFun",
("old_space", 0x05385): "AsyncFunctionAwaitResolveSharedFun",
("old_space", 0x053a9): "AsyncGeneratorAwaitRejectSharedFun",
("old_space", 0x053cd): "AsyncGeneratorAwaitResolveSharedFun",
("old_space", 0x053f1): "AsyncGeneratorYieldWithAwaitResolveSharedFun",
("old_space", 0x05415): "AsyncGeneratorReturnResolveSharedFun",
("old_space", 0x05439): "AsyncGeneratorReturnClosedRejectSharedFun",
("old_space", 0x0545d): "AsyncGeneratorReturnClosedResolveSharedFun",
("old_space", 0x05481): "AsyncIteratorValueUnwrapSharedFun",
("old_space", 0x054a5): "PromiseAllResolveElementSharedFun",
("old_space", 0x054c9): "PromiseAllSettledResolveElementSharedFun",
("old_space", 0x054ed): "PromiseAllSettledRejectElementSharedFun",
("old_space", 0x05511): "PromiseAnyRejectElementSharedFun",
("old_space", 0x05535): "PromiseCapabilityDefaultRejectSharedFun",
("old_space", 0x05559): "PromiseCapabilityDefaultResolveSharedFun",
("old_space", 0x0557d): "PromiseCatchFinallySharedFun",
("old_space", 0x055a1): "PromiseGetCapabilitiesExecutorSharedFun",
("old_space", 0x055c5): "PromiseThenFinallySharedFun",
("old_space", 0x055e9): "PromiseThrowerFinallySharedFun",
("old_space", 0x0560d): "PromiseValueThunkFinallySharedFun",
("old_space", 0x05631): "ProxyRevokeSharedFun",
("old_space", 0x05655): "ShadowRealmImportValueFulfilledSFI",
("old_space", 0x05679): "SourceTextModuleExecuteAsyncModuleFulfilledSFI",
("old_space", 0x0569d): "SourceTextModuleExecuteAsyncModuleRejectedSFI",
("old_space", 0x0426d): "ArgumentsIteratorAccessor",
("old_space", 0x04285): "ArrayLengthAccessor",
("old_space", 0x0429d): "BoundFunctionLengthAccessor",
("old_space", 0x042b5): "BoundFunctionNameAccessor",
("old_space", 0x042cd): "ErrorStackAccessor",
("old_space", 0x042e5): "FunctionArgumentsAccessor",
("old_space", 0x042fd): "FunctionCallerAccessor",
("old_space", 0x04315): "FunctionNameAccessor",
("old_space", 0x0432d): "FunctionLengthAccessor",
("old_space", 0x04345): "FunctionPrototypeAccessor",
("old_space", 0x0435d): "StringLengthAccessor",
("old_space", 0x04375): "ValueUnavailableAccessor",
("old_space", 0x0438d): "WrappedFunctionLengthAccessor",
("old_space", 0x043a5): "WrappedFunctionNameAccessor",
("old_space", 0x043bd): "ExternalMap",
("old_space", 0x043e5): "JSMessageObjectMap",
("old_space", 0x0440d): "EmptyScript",
("old_space", 0x04451): "ManyClosuresCell",
("old_space", 0x0445d): "ArrayConstructorProtector",
("old_space", 0x04471): "NoElementsProtector",
("old_space", 0x04485): "MegaDOMProtector",
("old_space", 0x04499): "IsConcatSpreadableProtector",
("old_space", 0x044ad): "ArraySpeciesProtector",
("old_space", 0x044c1): "TypedArraySpeciesProtector",
("old_space", 0x044d5): "PromiseSpeciesProtector",
("old_space", 0x044e9): "RegExpSpeciesProtector",
("old_space", 0x044fd): "StringLengthProtector",
("old_space", 0x04511): "ArrayIteratorProtector",
("old_space", 0x04525): "ArrayBufferDetachingProtector",
("old_space", 0x04539): "PromiseHookProtector",
("old_space", 0x0454d): "PromiseResolveProtector",
("old_space", 0x04561): "MapIteratorProtector",
("old_space", 0x04575): "PromiseThenProtector",
("old_space", 0x04589): "SetIteratorProtector",
("old_space", 0x0459d): "StringIteratorProtector",
("old_space", 0x045b1): "StringSplitCache",
("old_space", 0x049b9): "RegExpMultipleCache",
("old_space", 0x04dc1): "BuiltinsConstantsTable",
("old_space", 0x05391): "AsyncFunctionAwaitRejectSharedFun",
("old_space", 0x053b5): "AsyncFunctionAwaitResolveSharedFun",
("old_space", 0x053d9): "AsyncGeneratorAwaitRejectSharedFun",
("old_space", 0x053fd): "AsyncGeneratorAwaitResolveSharedFun",
("old_space", 0x05421): "AsyncGeneratorYieldWithAwaitResolveSharedFun",
("old_space", 0x05445): "AsyncGeneratorReturnResolveSharedFun",
("old_space", 0x05469): "AsyncGeneratorReturnClosedRejectSharedFun",
("old_space", 0x0548d): "AsyncGeneratorReturnClosedResolveSharedFun",
("old_space", 0x054b1): "AsyncIteratorValueUnwrapSharedFun",
("old_space", 0x054d5): "PromiseAllResolveElementSharedFun",
("old_space", 0x054f9): "PromiseAllSettledResolveElementSharedFun",
("old_space", 0x0551d): "PromiseAllSettledRejectElementSharedFun",
("old_space", 0x05541): "PromiseAnyRejectElementSharedFun",
("old_space", 0x05565): "PromiseCapabilityDefaultRejectSharedFun",
("old_space", 0x05589): "PromiseCapabilityDefaultResolveSharedFun",
("old_space", 0x055ad): "PromiseCatchFinallySharedFun",
("old_space", 0x055d1): "PromiseGetCapabilitiesExecutorSharedFun",
("old_space", 0x055f5): "PromiseThenFinallySharedFun",
("old_space", 0x05619): "PromiseThrowerFinallySharedFun",
("old_space", 0x0563d): "PromiseValueThunkFinallySharedFun",
("old_space", 0x05661): "ProxyRevokeSharedFun",
("old_space", 0x05685): "ShadowRealmImportValueFulfilledSFI",
("old_space", 0x056a9): "SourceTextModuleExecuteAsyncModuleFulfilledSFI",
("old_space", 0x056cd): "SourceTextModuleExecuteAsyncModuleRejectedSFI",
}
# Lower 32 bits of first page addresses for various heap spaces.