AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

Add tools/presubmit.py call to tools/test-wrapper-gypbuild.py

Browse Source 
Review URL: http://codereview.chromium.org/7785025

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@9081 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
This commit is contained in:
jkummerow@chromium.org 2011-08-31 13:01:28 +00:00
parent 227e679ce9
commit 829e174a02
2 changed files with 11 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
Makefile
View File

@ -98,8 +98,9 @@ CHECKS = $(addsuffix .check,$(BUILDS))
# File where previously used GYPFLAGS are stored.
ENVFILE = $(OUTDIR)/environment
.PHONY: all clean $(ENVFILE).new \
$(ARCHES) $(MODES) $(BUILDS) $(addsuffix .clean,$(ARCHES))
.PHONY: all check clean $(ENVFILE).new \
$(ARCHES) $(MODES) $(BUILDS) $(CHECKS) $(addsuffix .clean,$(ARCHES)) \
$(addsuffix .check,$(MODES)) $(addsuffix .check,$(ARCHES))
# Target definitions. "all" is the default.
all: $(MODES)

8
tools/test-wrapper-gypbuild.py
View File

@ -53,6 +53,9 @@ def BuildOptions():
result.add_option("--outdir",
help='Base output directory',
default='out')
result.add_option("--no-presubmit",
help='Skip presubmit checks',
default=False, action="store_true")
# Flags this wrapper script handles itself:
result.add_option("-m", "--mode",
@ -202,6 +205,11 @@ def Main():
return 1
workspace = abspath(join(dirname(sys.argv[0]), '..'))
if not options.no_presubmit:
print ">>> running presubmit tests"
subprocess.call([workspace + '/tools/presubmit.py'])
args_for_children = [workspace + '/tools/test.py'] + PassOnOptions(options)
args_for_children += ['--no-build', '--build-system=gyp']
for arg in args: