From 835a2c12e0cc6989c25f29c4d7259b4ea3a58a59 Mon Sep 17 00:00:00 2001
From: Victor Gomes <victorgomes@chromium.org>
Date: Mon, 12 Dec 2022 16:28:05 +0100
Subject: [PATCH] [maglev][arm64] Add CheckedInternalizedString

Bug: v8:7700
Change-Id: I1d0c29dabd3bec177662007de314b27d448a4e39
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4096858
Auto-Submit: Victor Gomes <victorgomes@chromium.org>
Commit-Queue: Darius Mercadier <dmercadier@chromium.org>
Commit-Queue: Victor Gomes <victorgomes@chromium.org>
Reviewed-by: Darius Mercadier <dmercadier@chromium.org>
Cr-Commit-Position: refs/heads/main@{#84788}
---
 src/maglev/arm64/maglev-ir-arm64.cc | 55 ++++++++++++++++++++++++++++-
 1 file changed, 54 insertions(+), 1 deletion(-)

diff --git a/src/maglev/arm64/maglev-ir-arm64.cc b/src/maglev/arm64/maglev-ir-arm64.cc
index 027642c5f1..1291e0c185 100644
--- a/src/maglev/arm64/maglev-ir-arm64.cc
+++ b/src/maglev/arm64/maglev-ir-arm64.cc
@@ -141,7 +141,6 @@ UNIMPLEMENTED_NODE(LoadSignedIntTypedArrayElement, elements_kind_)
 UNIMPLEMENTED_NODE(LoadUnsignedIntTypedArrayElement, elements_kind_)
 UNIMPLEMENTED_NODE(LoadDoubleTypedArrayElement, elements_kind_)
 UNIMPLEMENTED_NODE(CheckedSmiTagUint32)
-UNIMPLEMENTED_NODE(CheckedInternalizedString, check_type_)
 UNIMPLEMENTED_NODE_WITH_CALL(CheckedObjectToIndex)
 UNIMPLEMENTED_NODE(CheckedTruncateNumberToInt32)
 UNIMPLEMENTED_NODE(CheckedInt32ToUint32)
@@ -509,6 +508,60 @@ void CheckedSmiTagInt32::GenerateCode(MaglevAssembler* masm,
   __ EmitEagerDeoptIf(vs, DeoptimizeReason::kOverflow, this);
 }
 
+void CheckedInternalizedString::SetValueLocationConstraints() {
+  UseRegister(object_input());
+  DefineSameAsFirst(this);
+}
+void CheckedInternalizedString::GenerateCode(MaglevAssembler* masm,
+                                             const ProcessingState& state) {
+  UseScratchRegisterScope temps(masm);
+  Register scratch = temps.AcquireX();
+  Register object = ToRegister(object_input());
+
+  if (check_type_ == CheckType::kOmitHeapObjectCheck) {
+    __ AssertNotSmi(object);
+  } else {
+    Condition is_smi = __ CheckSmi(object);
+    __ EmitEagerDeoptIf(is_smi, DeoptimizeReason::kWrongMap, this);
+  }
+
+  __ LoadMap(scratch, object);
+  __ RecordComment("Test IsInternalizedString");
+  // Go to the slow path if this is a non-string, or a non-internalised string.
+  __ Ldrh(scratch, FieldMemOperand(scratch, Map::kInstanceTypeOffset));
+  __ Tst(scratch, Immediate(kIsNotStringMask | kIsNotInternalizedMask));
+  static_assert((kStringTag | kInternalizedTag) == 0);
+  ZoneLabelRef done(masm);
+  __ JumpToDeferredIf(
+      ne,
+      [](MaglevAssembler* masm, ZoneLabelRef done, Register object,
+         CheckedInternalizedString* node, EagerDeoptInfo* deopt_info,
+         Register instance_type) {
+        __ RecordComment("Deferred Test IsThinString");
+        static_assert(kThinStringTagBit > 0);
+        // Deopt if this isn't a string.
+        __ Tst(instance_type, Immediate(kIsNotStringMask));
+        __ JumpIf(ne, deopt_info->deopt_entry_label());
+        // Deopt if this isn't a thin string.
+        __ Tst(instance_type, Immediate(kThinStringTagBit));
+        __ JumpIf(eq, deopt_info->deopt_entry_label());
+        __ LoadTaggedPointerField(
+            object, FieldMemOperand(object, ThinString::kActualOffset));
+        if (v8_flags.debug_code) {
+          __ RecordComment("DCHECK IsInternalizedString");
+          Register scratch = instance_type;
+          __ LoadMap(scratch, object);
+          __ Ldrh(scratch, FieldMemOperand(scratch, Map::kInstanceTypeOffset));
+          __ Tst(scratch, Immediate(kIsNotStringMask | kIsNotInternalizedMask));
+          static_assert((kStringTag | kInternalizedTag) == 0);
+          __ Check(eq, AbortReason::kUnexpectedValue);
+        }
+        __ jmp(*done);
+      },
+      done, object, this, eager_deopt_info(), scratch);
+  __ bind(*done);
+}
+
 void UnsafeSmiTag::SetValueLocationConstraints() {
   UseRegister(input());
   DefineAsRegister(this);