AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[torque] Reduce includes for debug-macros.h

Browse Source 
Removes unneeded dependency on src/builtins/torque-csa-header-includes.h
from debug-macros.h and adds swiss-name-dictionary.h and
ordered-hash-table.h to debug-macros.cc.

Additionally adds a v8_libbase dep to torque_generated_definitions. As
a result, gn check errors are reduced by 2.

Bug: v8:7330
Change-Id: I0ff666eebd6814e4d52d776e455fd269db36b589
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2744040
Reviewed-by: Nico Hartmann <nicohartmann@chromium.org>
Commit-Queue: Dan Elphick <delphick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#73291}
This commit is contained in:
Dan Elphick 2021-03-09 12:07:18 +00:00 committed by Commit Bot
parent 217b4cd690
commit 8378a1beb7
2 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
BUILD.gn
View File

@ -1626,6 +1626,7 @@ v8_source_set("torque_generated_definitions") {
":generate_bytecode_builtins_list",
":run_torque",
":v8_internal_headers",
":v8_libbase",
":v8_tracing",
]

5
src/torque/implementation-visitor.cc
View File

@ -154,6 +154,8 @@ void ImplementationVisitor::BeginDebugMacrosFile() {
std::ostream& header = debug_macros_h_;
source << "#include \"torque-generated/debug-macros.h\"\n\n";
source << "#include \"src/objects/swiss-name-dictionary.h\"\n";
source << "#include \"src/objects/ordered-hash-table.h\"\n";
source << "#include \"tools/debug_helper/debug-macro-shims.h\"\n";
source << "#include \"include/v8-internal.h\"\n";
source << "\n";
@ -166,13 +168,12 @@ void ImplementationVisitor::BeginDebugMacrosFile() {
const char* kHeaderDefine = "V8_GEN_TORQUE_GENERATED_DEBUG_MACROS_H_";
header << "#ifndef " << kHeaderDefine << "\n";
header << "#define " << kHeaderDefine << "\n\n";
header << "#include \"src/builtins/torque-csa-header-includes.h\"\n";
header << "#include \"tools/debug_helper/debug-helper-internal.h\"\n";
header << "\n";
header << "namespace v8 {\n"
<< "namespace internal {\n"
<< "namespace debug_helper_internal{\n"
<< "namespace debug_helper_internal {\n"
<< "\n";
}