AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

Do not use CodeStub::FindInCache if not necessary.

Browse Source 
GetCode does the FindInCache check as well.

R=mvstanton@chromium.org

Review URL: https://codereview.chromium.org/548313002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23795 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
This commit is contained in:
yangguo@chromium.org 2014-09-09 11:45:53 +00:00
parent 4b0c076052
commit 8470a7783b
3 changed files with 7 additions and 23 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
src/arm/code-stubs-arm.cc
View File

@ -976,20 +976,10 @@ void CodeStub::GenerateStubsAheadOfTime(Isolate* isolate) {
void CodeStub::GenerateFPStubs(Isolate* isolate) { void CodeStub::GenerateFPStubs(Isolate* isolate) {
// Generate if not already in cache.
SaveFPRegsMode mode = kSaveFPRegs; SaveFPRegsMode mode = kSaveFPRegs;
CEntryStub save_doubles(isolate, 1, mode); CEntryStub(isolate, 1, mode).GetCode();
StoreBufferOverflowStub stub(isolate, mode); StoreBufferOverflowStub(isolate, mode).GetCode();
// These stubs might already be in the snapshot, detect that and don't
// regenerate, which would lead to code stub initialization state being messed
// up.
Code* save_doubles_code;
if (!save_doubles.FindCodeInCache(&save_doubles_code)) {
save_doubles_code = *save_doubles.GetCode();
}
Code* store_buffer_overflow_code;
if (!stub.FindCodeInCache(&store_buffer_overflow_code)) {
store_buffer_overflow_code = *stub.GetCode();
}
isolate->set_fp_stubs_generated(true); isolate->set_fp_stubs_generated(true);
} }

3
src/code-stubs.cc
View File

@ -134,8 +134,7 @@ Handle<Code> PlatformCodeStub::GenerateCode() {
Handle<Code> CodeStub::GetCode() { Handle<Code> CodeStub::GetCode() {
Heap* heap = isolate()->heap(); Heap* heap = isolate()->heap();
Code* code; Code* code;
if (UseSpecialCache() if (UseSpecialCache() ? FindCodeInSpecialCache(&code)
? FindCodeInSpecialCache(&code)
: FindCodeInCache(&code)) { : FindCodeInCache(&code)) {
DCHECK(GetCodeKind() == code->kind()); DCHECK(GetCodeKind() == code->kind());
return Handle<Code>(code); return Handle<Code>(code);

9
src/ia32/code-stubs-ia32.cc
View File

@ -2273,13 +2273,8 @@ void CodeStub::GenerateStubsAheadOfTime(Isolate* isolate) {
void CodeStub::GenerateFPStubs(Isolate* isolate) { void CodeStub::GenerateFPStubs(Isolate* isolate) {
CEntryStub save_doubles(isolate, 1, kSaveFPRegs); // Generate if not already in cache.
// Stubs might already be in the snapshot, detect that and don't regenerate, CEntryStub(isolate, 1, kSaveFPRegs).GetCode();
// which would lead to code stub initialization state being messed up.
Code* save_doubles_code;
if (!save_doubles.FindCodeInCache(&save_doubles_code)) {
save_doubles_code = *(save_doubles.GetCode());
}
isolate->set_fp_stubs_generated(true); isolate->set_fp_stubs_generated(true);
} }