AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

Don't turn objects with empty-string properties into fast-mode.

Browse Source 
R=ishell@chromium.org

Review URL: https://codereview.chromium.org/165743003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19511 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
This commit is contained in:
verwaest@chromium.org 2014-02-20 16:11:48 +00:00
parent bb27633433
commit 84b366516e
2 changed files with 14 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/objects.cc
View File

@ -15710,6 +15710,7 @@ MaybeObject* NameDictionary::TransformPropertiesToFastFor(
// instance descriptor.
MaybeObject* maybe_key = heap->InternalizeString(String::cast(k));
if (!maybe_key->To(&key)) return maybe_key;
if (key->Equals(heap->empty_string())) return this;
}
PropertyDetails details = DetailsAt(i);

13
test/mjsunit/regress/regress-fast-empty-string.js Normal file
View File

@ -0,0 +1,13 @@
// Copyright 2014 the V8 project authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
var o = {};
o[""] = 1;
var x = {__proto__:o};
for (i = 0; i < 3; i++) {
o[""];
}
for (i = 0; i < 3; i++) {
assertEquals(undefined, o.x);
}