AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[nci] Remove the nci test variants

Browse Source 
They've started failed, and no work is planned for the foreseeable
future.

Bug: v8:8888
Change-Id: I89dfa8f972a5bffa2bbb09c7a6ca56a0c4da9a02
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2656316
Commit-Queue: Jakob Gruber <jgruber@chromium.org>
Auto-Submit: Jakob Gruber <jgruber@chromium.org>
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Cr-Commit-Position: refs/heads/master@{#72407}
This commit is contained in:
Jakob Gruber 2021-01-28 16:47:13 +01:00 committed by Commit Bot
parent 036e970db0
commit 84dec706d5
5 changed files with 2 additions and 169 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
infra/testing/builders.pyl
View File

@ -357,9 +357,6 @@
'tests': [
# Infra staging.
{'name': 'v8testing', 'variant': 'infra_staging', 'shards': 2},
# Native context independent code.
{'name': 'v8testing', 'variant': 'nci'},
{'name': 'v8testing', 'variant': 'nci_as_midtier'},
# Stress sampling.
{'name': 'mjsunit', 'variant': 'stress_sampling'},
{'name': 'webkit', 'variant': 'stress_sampling'},
@ -1113,9 +1110,6 @@
'tests': [
# Infra staging.
{'name': 'v8testing', 'variant': 'infra_staging', 'shards': 2},
# Native context independent code.
{'name': 'v8testing', 'variant': 'nci'},
{'name': 'v8testing', 'variant': 'nci_as_midtier'},
# Stress sampling.
{'name': 'mjsunit', 'variant': 'stress_sampling'},
{'name': 'webkit', 'variant': 'stress_sampling'},
@ -1145,9 +1139,6 @@
'tests': [
# Infra staging.
{'name': 'v8testing', 'variant': 'infra_staging'},
# Native context independent code.
{'name': 'v8testing', 'variant': 'nci'},
{'name': 'v8testing', 'variant': 'nci_as_midtier'},
# Stress sampling.
{'name': 'mjsunit', 'variant': 'stress_sampling'},
{'name': 'webkit', 'variant': 'stress_sampling'},

20
test/cctest/cctest.status
View File

@ -643,24 +643,4 @@
'*': [SKIP], # only relevant for mjsunit tests.
}],
################################################################################
['variant == nci or variant == nci_as_midtier', {
# Optimizes and deopts differently than TurboFan.
'test-api/FastApiCalls': [SKIP],
'test-cpu-profiler/Deopt*': [SKIP],
'test-cpu-profiler/DetailedSourcePositionAPI_Inlining': [SKIP],
'test-cpu-profiler/DetailedSourcePositionAPI': [SKIP],
'test-heap/CellsInOptimizedCodeAreWeak': [SKIP],
'test-heap/EnsureAllocationSiteDependentCodesProcessed': [SKIP],
'test-heap/NewSpaceObjectsInOptimizedCode': [SKIP],
'test-heap/ObjectsInEagerlyDeoptimizedCodeAreWeak': [SKIP],
'test-heap/ObjectsInOptimizedCodeAreWeak': [SKIP],
'test-heap/OptimizedPretenuring*': [SKIP],
'test-heap-profiler/SamplingHeapProfilerPretenuredInlineAllocations': [SKIP],
'test-log/LogAll': [SKIP],
# NCI code currently does not use the feedback vector's optimized code cache.
'test-compiler/OptimizedCodeSharing1': [SKIP],
}], # variant == nci or variant == nci_as_midtier
]

4
test/debugger/debugger.status
View File

@ -140,11 +140,11 @@
}], # lite_mode or variant == jitless
##############################################################################
['variant == turboprop or variant == turboprop_as_toptier or variant == nci or variant == nci_as_midtier', {
['variant == turboprop or variant == turboprop_as_toptier', {
# Deopts differently than TurboFan.
'debug/debug-optimize': [SKIP],
'debug/debug-compile-optimized': [SKIP],
}], # variant == turboprop or variant == turboprop_as_toptier or variant == nci or variant == nci_as_midtier
}], # variant == turboprop or variant == turboprop_as_toptier
##############################################################################
# Liftoff needs to be enabled before running these tests.

136
test/mjsunit/mjsunit.status
View File

@ -1318,142 +1318,6 @@
'regress/wasm/regress-9017': [SKIP],
}], # variant == slow_path
################################################################################
['variant == nci or variant == nci_as_midtier', {
# Deopts differently than TurboFan.
# Deoptimization support is still incomplete in general, since deopts can
# only happen when explicitly requested by tests. NCI code objects are then
# set as marked_for_deoptimization *and never unset*, which means functions
# with attached NCI code objects will never again count as optimized.
# TODO(jgruber): Fix this once deopts can occur outside tests.
'compiler/is-being-interpreted*': [SKIP],
'compiler/number-comparison-truncations': [SKIP],
'compiler/redundancy-elimination': [SKIP],
'compiler/regress-9945-*': [SKIP],
'regress/regress-1049982-1': [SKIP],
'regress/regress-1049982-2': [SKIP],
'compiler/test-dynamic-map-*': [SKIP],
'es6/collections-constructor-iterator-side-effect': [SKIP],
'es6/collections-constructor-with-modified-protoype': [SKIP],
# assertUnoptimized: assumes full turbofan pipeline.
'allocation-site-info': [SKIP],
'array-bounds-check-removal': [SKIP],
'array-constructor-feedback': [SKIP],
'array-literal-feedback': [SKIP],
'array-literal-transitions': [SKIP],
'array-push5': [SKIP],
'array-store-and-grow': [SKIP],
'check-bounds-array-index': [SKIP],
'check-bounds-string-from-char-code-at': [SKIP],
'compiler/abstract-equal-oddball': [SKIP],
'compiler/abstract-equal-receiver': [SKIP],
'compiler/abstract-equal-symbol': [SKIP],
'compiler/abstract-equal-undetectable': [SKIP],
'compiler/array-multiple-receiver-maps': [SKIP],
'compiler/bigint-add-no-deopt-loop': [SKIP],
'compiler/bound-functions-serialize': [SKIP],
'compiler/concurrent-invalidate-transition-map': [SKIP],
'compiler/concurrent-proto-change': [SKIP],
'compiler/constant-fold-cow-array': [SKIP],
'compiler/dataview-deopt': [SKIP],
'compiler/dataview-detached': [SKIP],
'compiler/dataview-get': [SKIP],
'compiler/dataview-set': [SKIP],
'compiler/deopt-inlined-from-call': [SKIP],
'compiler/field-representation-tracking': [SKIP],
'compiler/globals-change-writable': [SKIP],
'compiler/globals-freeze-*': [SKIP],
'compiler/manual-concurrent-recompile': [SKIP],
'compiler/native-context-specialization-hole-check': [SKIP],
'compiler/number-divide': [SKIP],
'compiler/opt-higher-order-functions': [SKIP],
'compiler/promise-resolve-stable-maps': [SKIP],
'compiler/regress-905555-2': [SKIP],
'compiler/regress-905555': [SKIP],
'compiler/regress-9945-1': [SKIP],
'compiler/regress-9945-2': [SKIP],
'compiler/stress-deopt-count-2': [SKIP],
'compiler/strict-equal-receiver': [SKIP],
'compiler/string-from-code-point': [SKIP],
'concurrent-initial-prototype-change': [SKIP],
'const-field-tracking-2': [SKIP],
'const-field-tracking': [SKIP],
'deopt-recursive-eager-once': [SKIP],
'deopt-recursive-lazy-once': [SKIP],
'deopt-recursive-soft-once': [SKIP],
'deopt-unlinked': [SKIP],
'deopt-with-fp-regs': [SKIP],
'ensure-growing-store-learns': [SKIP],
'es6/array-iterator-turbo': [SKIP],
'es6/iterator-eager-deopt': [SKIP],
'es6/iterator-lazy-deopt': [SKIP],
'field-type-tracking': [SKIP],
'frozen-array-reduce': [SKIP],
'getters-on-elements': [SKIP],
'harmony/regexp-overriden-exec': [SKIP],
'keyed-load-hole-to-undefined': [SKIP],
'keyed-load-with-symbol-key': [SKIP],
'mjsunit_numfuzz': [SKIP],
'mjsunit': [SKIP],
'never-optimize': [SKIP],
'non-extensible-array-reduce': [SKIP],
'noopt': [SKIP],
'object-seal': [SKIP],
'optimized-array-every': [SKIP],
'optimized-array-findindex': [SKIP],
'optimized-array-find': [SKIP],
'optimized-array-some': [SKIP],
'optimized-filter': [SKIP],
'optimized-map': [SKIP],
'regress/regress-1016450': [SKIP],
'regress/regress-1034449': [SKIP],
'regress/regress-1073440': [SKIP],
'regress/regress-1112155': [SKIP],
'regress/regress-347914': [SKIP],
'regress/regress-3709': [SKIP],
'regress/regress-385565': [SKIP],
'regress/regress-410912': [SKIP],
'regress/regress-618608': [SKIP],
'regress/regress-9002': [SKIP],
'regress/regress-9441': [SKIP],
'regress/regress-961709-classes-opt': [SKIP],
'regress/regress-bind-deoptimize': [SKIP],
'regress/regress-crbug-500497': [SKIP],
'regress/regress-crbug-594183': [SKIP],
'regress/regress-embedded-cons-string': [SKIP],
'regress/regress-unlink-closures-on-deopt': [SKIP],
'regress/wasm/regress-02256b': [SKIP],
'regress/wasm/regress-02256': [SKIP],
'sealed-array-reduce': [SKIP],
'setters-on-elements': [SKIP],
'smi-mul-const': [SKIP],
'smi-mul': [SKIP],
'unary-minus-deopt': [SKIP],
# TurbofanStaticAssert: assumes full turbofan pipeline.
'compiler/catch-block-load': [SKIP],
'compiler/concurrent-inlining-1': [SKIP],
'compiler/concurrent-inlining-2': [SKIP],
'compiler/constant-fold-add-static': [SKIP],
'compiler/construct-bound-function': [SKIP],
'compiler/construct-object': [SKIP],
'compiler/construct-receiver': [SKIP],
'compiler/diamond-followedby-branch': [SKIP],
'compiler/inlined-call-polymorphic': [SKIP],
'compiler/js-create-arguments': [SKIP],
'compiler/js-create': [SKIP],
'compiler/load-elimination-const-field': [SKIP],
'compiler/serializer-accessors': [SKIP],
'compiler/serializer-apply': [SKIP],
'compiler/serializer-call': [SKIP],
'compiler/serializer-dead-after-jump': [SKIP],
'compiler/serializer-dead-after-return': [SKIP],
'compiler/serializer-feedback-propagation-1': [SKIP],
'compiler/serializer-feedback-propagation-2': [SKIP],
'compiler/serializer-transition-propagation': [SKIP],
# crbug.com/v8/11110
'es6/super-ic-opt*': [SKIP],
}], # variant == nci or variant == nci_as_midtier
['((arch == mipsel or arch == mips64el or arch == mips or arch == mips64) and not simd_mips) or (arch in [ppc64, s390x])', {
# Requires scalar lowering for 64x2 SIMD instructions, which are not
# implemented yet.

2
tools/testrunner/local/variants.py
View File

@ -15,8 +15,6 @@ ALL_VARIANT_FLAGS = {
"experimental_regexp": [["--default-to-experimental-regexp-engine"]],
"jitless": [["--jitless"]],
"minor_mc": [["--minor-mc"]],
"nci": [["--turbo-nci"]],
"nci_as_midtier": [["--turbo-nci-as-midtier"]],
"no_lfa": [["--no-lazy-feedback-allocation"]],
"no_local_heaps": [[
"--no-local-heaps",