AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

Convert GN visibility to be a list.

Browse Source 
GN visibility currently allows either string or list types, but this is causing
some problems for some templates. I'm going to require it to be lists, so am
changing all callers before pushing the new binary.

R=jochen@chromium.org

Review URL: https://codereview.chromium.org/556583002

Patch from Brett Wilson <brettw@chromium.org>.

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23789 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
This commit is contained in:
jochen@chromium.org 2014-09-09 08:57:29 +00:00
parent 51d11d4e19
commit 84e21c5ec0
1 changed files with 15 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

30
BUILD.gn
View File

@ -25,7 +25,7 @@ v8_random_seed = "314159265"
# Configurations
#
config("internal_config") {
visibility = ":*" # Only targets in this file can depend on this.
visibility = [ ":*" ] # Only targets in this file can depend on this.
include_dirs = [ "." ]
@ -38,7 +38,7 @@ config("internal_config") {
}
config("internal_config_base") {
visibility = ":*" # Only targets in this file can depend on this.
visibility = [ ":*" ] # Only targets in this file can depend on this.
include_dirs = [ "." ]
}
@ -56,7 +56,7 @@ config("external_config") {
}
config("features") {
visibility = ":*" # Only targets in this file can depend on this.
visibility = [ ":*" ] # Only targets in this file can depend on this.
defines = []
@ -118,7 +118,7 @@ config("features") {
}
config("toolchain") {
visibility = ":*" # Only targets in this file can depend on this.
visibility = [ ":*" ] # Only targets in this file can depend on this.
defines = []
cflags = []
@ -167,7 +167,7 @@ config("toolchain") {
#
action("js2c") {
visibility = ":*" # Only targets in this file can depend on this.
visibility = [ ":*" ] # Only targets in this file can depend on this.
script = "tools/js2c.py"
@ -228,7 +228,7 @@ action("js2c") {
}
action("js2c_experimental") {
visibility = ":*" # Only targets in this file can depend on this.
visibility = [ ":*" ] # Only targets in this file can depend on this.
script = "tools/js2c.py"
@ -266,7 +266,7 @@ action("js2c_experimental") {
if (v8_use_external_startup_data) {
action("natives_blob") {
visibility = ":*" # Only targets in this file can depend on this.
visibility = [ ":*" ] # Only targets in this file can depend on this.
deps = [
":js2c",
@ -289,7 +289,7 @@ if (v8_use_external_startup_data) {
}
action("postmortem-metadata") {
visibility = ":*" # Only targets in this file can depend on this.
visibility = [ ":*" ] # Only targets in this file can depend on this.
script = "tools/gen-postmortem-metadata.py"
@ -308,7 +308,7 @@ action("postmortem-metadata") {
}
action("run_mksnapshot") {
visibility = ":*" # Only targets in this file can depend on this.
visibility = [ ":*" ] # Only targets in this file can depend on this.
deps = [ ":mksnapshot($host_toolchain)" ]
@ -346,7 +346,7 @@ action("run_mksnapshot") {
#
source_set("v8_nosnapshot") {
visibility = ":*" # Only targets in this file can depend on this.
visibility = [ ":*" ] # Only targets in this file can depend on this.
deps = [
":js2c",
@ -367,7 +367,7 @@ source_set("v8_nosnapshot") {
}
source_set("v8_snapshot") {
visibility = ":*" # Only targets in this file can depend on this.
visibility = [ ":*" ] # Only targets in this file can depend on this.
deps = [
":js2c",
@ -390,7 +390,7 @@ source_set("v8_snapshot") {
if (v8_use_external_startup_data) {
source_set("v8_external_snapshot") {
visibility = ":*" # Only targets in this file can depend on this.
visibility = [ ":*" ] # Only targets in this file can depend on this.
deps = [
":js2c",
@ -412,7 +412,7 @@ if (v8_use_external_startup_data) {
}
source_set("v8_base") {
visibility = ":*" # Only targets in this file can depend on this.
visibility = [ ":*" ] # Only targets in this file can depend on this.
sources = [
"src/accessors.cc",
@ -1157,7 +1157,7 @@ source_set("v8_base") {
}
source_set("v8_libbase") {
visibility = ":*" # Only targets in this file can depend on this.
visibility = [ ":*" ] # Only targets in this file can depend on this.
sources = [
"src/base/atomicops.h",
@ -1282,7 +1282,7 @@ source_set("v8_libplatform") {
if (current_toolchain == host_toolchain) {
executable("mksnapshot") {
visibility = ":*" # Only targets in this file can depend on this.
visibility = [ ":*" ] # Only targets in this file can depend on this.
sources = [
"src/mksnapshot.cc",