From 85238bd778bd38be58f016107dfa56b901c921b9 Mon Sep 17 00:00:00 2001 From: Clemens Backes Date: Tue, 24 Mar 2020 08:35:55 +0100 Subject: [PATCH] Fix cputracemark extension If the type check fails, we should return. Otherwise we hit an error in ToLocalChecked below. R=yangguo@chromium.org Bug: chromium:1061673 Change-Id: I39e5b90b3574d0d2b77f5d704023aabb1c8130cb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2116035 Reviewed-by: Yang Guo Commit-Queue: Clemens Backes Cr-Commit-Position: refs/heads/master@{#66901} --- src/extensions/cputracemark-extension.cc | 1 + 1 file changed, 1 insertion(+) diff --git a/src/extensions/cputracemark-extension.cc b/src/extensions/cputracemark-extension.cc index 0528e155ee..9dfa9761fd 100644 --- a/src/extensions/cputracemark-extension.cc +++ b/src/extensions/cputracemark-extension.cc @@ -19,6 +19,7 @@ void CpuTraceMarkExtension::Mark( args.GetIsolate()->ThrowException(v8::String::NewFromUtf8Literal( args.GetIsolate(), "First parameter to cputracemark() must be a unsigned int32.")); + return; } #if V8_HOST_ARCH_IA32 || V8_HOST_ARCH_X64