AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[inspector] Fix memory leaks in inspector test

Browse Source 
Bug: v8:7932
Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Ia29e9e62022f0820c3a5aaf48a7724b13b61b275
Reviewed-on: https://chromium-review.googlesource.com/1143186
Reviewed-by: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
Cr-Commit-Position: refs/heads/master@{#54567}
This commit is contained in:
Sigurd Schneider 2018-07-19 11:35:49 +02:00 committed by Commit Bot
parent 08caf18c58
commit 85cf39d4f9
1 changed files with 9 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
test/inspector/inspector-test.cc
View File

@ -107,7 +107,7 @@ class FrontendChannelImpl : public v8_inspector::V8Inspector::Channel {
SendMessageTask(FrontendChannelImpl* channel,
const v8::internal::Vector<uint16_t>& message)
: channel_(channel), message_(message) {}
virtual ~SendMessageTask() {}
virtual ~SendMessageTask() { message_.Dispose(); }
bool is_priority_task() final { return false; }
private:
@ -215,6 +215,11 @@ class ExecuteStringTask : public TaskRunner::Task {
ExecuteStringTask(const v8::internal::Vector<const char>& expression,
int context_group_id)
: expression_utf8_(expression), context_group_id_(context_group_id) {}
virtual ~ExecuteStringTask() {
if (expression_.start()) expression_.Dispose();
if (expression_utf8_.start()) expression_utf8_.Dispose();
}
bool is_priority_task() override { return false; }
void Run(IsolateData* data) override {
v8::MicrotasksScope microtasks_scope(data->isolate(),
@ -391,8 +396,10 @@ class UtilsExtension : public IsolateData::SetupGlobalTask {
}
v8::internal::Vector<const char> chars;
v8::Isolate* isolate = args.GetIsolate();
if (ReadFile(isolate, args[0], &chars))
if (ReadFile(isolate, args[0], &chars)) {
args.GetReturnValue().Set(ToV8String(isolate, chars.start()));
chars.Dispose();
}
}
static void Load(const v8::FunctionCallbackInfo<v8::Value>& args) {