AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

Revert "Reland "Enable cfi-icall on the v8 CFI bots""

Browse Source 
This reverts commit cfd7df1bb6.

Reason for revert: Seems to flush out more problems:
https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20-%20cfi/builds/14390

Original change's description:
> Reland "Enable cfi-icall on the v8 CFI bots"
> 
> This is a reland of 9a7e9cf2a7
> 
> Original change's description:
> > Enable cfi-icall on the v8 CFI bots
> > 
> > BUG=v8:7164
> > 
> > Change-Id: I7522ba6ac2bde89c84bcd49bc116a432091a2938
> > Reviewed-on: https://chromium-review.googlesource.com/990802
> > Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
> > Reviewed-by: Clemens Hammacher <clemensh@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#52343}
> 
> Bug: v8:7164
> Change-Id: Ia883adedf9d54e4a2518d66c85799354d930990e
> Reviewed-on: https://chromium-review.googlesource.com/996133
> Reviewed-by: Clemens Hammacher <clemensh@chromium.org>
> Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#52425}

TBR=machenbach@chromium.org,clemensh@chromium.org,vtsyrklevich@chromium.org

Change-Id: I5a45756f7e2e74ac50ae9fb93716b9083cdf4379
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: v8:7164
Reviewed-on: https://chromium-review.googlesource.com/999633
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Commit-Queue: Michael Achenbach <machenbach@chromium.org>
Cr-Commit-Position: refs/heads/master@{#52431}
This commit is contained in:
Michael Achenbach 2018-04-06 10:49:53 +00:00 committed by Commit Bot
parent 04246dcc1b
commit 85d98578b4
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
infra/mb/mb_config.pyl
View File

@ -556,14 +556,14 @@
'cfi': {
'mixins': ['v8_enable_test_features'],
'gn_args': ('is_cfi=true use_cfi_cast=true use_cfi_icall=true '
'use_cfi_diag=true use_cfi_recover=false'),
'gn_args': ('is_cfi=true use_cfi_cast=true use_cfi_diag=true '
'use_cfi_recover=false'),
},
'cfi_clusterfuzz': {
'mixins': ['v8_enable_test_features'],
'gn_args': ('is_cfi=true use_cfi_cast=true use_cfi_icall=true '
'use_cfi_diag=true use_cfi_recover=true'),
'gn_args': ('is_cfi=true use_cfi_cast=true use_cfi_diag=true '
'use_cfi_recover=true'),
},
'clang': {