AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[build] Don't run orphaned action in default builds

Browse Source 
A gn build with no specified targets builds all visible targets. The
postmortem-metadata action is visible, but its output is only needed
if v8_postmortem_support is enabled, hence we now guard the whole
action by the flag.

Depends on https://crrev.com/c/4064686

Bug: chromium:1394626
Change-Id: I8444021cfe253cedee5c1578c733a3ad973726db
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4061865
Reviewed-by: Victor Gomes <victorgomes@chromium.org>
Reviewed-by: Liviu Rau <liviurau@chromium.org>
Commit-Queue: Michael Achenbach <machenbach@chromium.org>
Cr-Commit-Position: refs/heads/main@{#84599}
This commit is contained in:
Michael Achenbach 2022-11-30 08:33:53 +01:00 committed by V8 LUCI CQ
parent f06b360249
commit 8606191c98
1 changed files with 84 additions and 82 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
BUILD.gn
View File

@ -1582,7 +1582,8 @@ if (is_android && enable_java_templates) {
}
}
action("postmortem-metadata") {
if (v8_postmortem_support) {
action("postmortem-metadata") {
# Only targets in this file and the top-level visibility target can
# depend on this.
visibility = [
@ -1669,6 +1670,7 @@ action("postmortem-metadata") {
rebase_path(sources, root_build_dir)
deps = [ ":run_torque" ]
}
}
torque_files = [