AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

Make sure use of eax in inlined sin and cos is safe.

Browse Source 
Review URL: http://codereview.chromium.org/164061

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@2639 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
This commit is contained in:
whesse@chromium.org 2009-08-06 14:42:38 +00:00
parent 384a6f299e
commit 863582bad4
1 changed files with 12 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
src/ia32/codegen-ia32.cc
View File

@ -754,9 +754,9 @@ class FloatingPointHelper : public AllStatic {
public: public:
// Code pattern for loading a floating point value. Input value must // Code pattern for loading a floating point value. Input value must
// be either a smi or a heap number object (fp value). Requirements: // be either a smi or a heap number object (fp value). Requirements:
// operand on TOS+1. Returns operand as floating point number on FPU // operand in register number. Returns operand as floating point number
// stack. // on FPU stack.
static void LoadFloatOperand(MacroAssembler* masm, Register scratch); static void LoadFloatOperand(MacroAssembler* masm, Register number);
// Code pattern for loading floating point values. Input values must // Code pattern for loading floating point values. Input values must
// be either smi or heap number objects (fp values). Requirements: // be either smi or heap number objects (fp values). Requirements:
// operand_1 on TOS+1 , operand_2 on TOS+2; Returns operands as // operand_1 on TOS+1 , operand_2 on TOS+2; Returns operands as
@ -5164,8 +5164,11 @@ void CodeGenerator::GenerateFastMathOp(MathOp op, ZoneList<Expression*>* args) {
} }
// Go slow case if argument to operation is out of range. // Go slow case if argument to operation is out of range.
Result eax_reg = allocator_->Allocate(eax);
ASSERT(eax_reg.is_valid());
__ fnstsw_ax(); __ fnstsw_ax();
__ sahf(); __ sahf();
eax_reg.Unuse();
call_runtime.Branch(parity_even, not_taken); call_runtime.Branch(parity_even, not_taken);
// Allocate heap number for result if possible. // Allocate heap number for result if possible.
@ -6964,19 +6967,19 @@ void FloatingPointHelper::AllocateHeapNumber(MacroAssembler* masm,
void FloatingPointHelper::LoadFloatOperand(MacroAssembler* masm, void FloatingPointHelper::LoadFloatOperand(MacroAssembler* masm,
Register scratch) { Register number) {
Label load_smi, done; Label load_smi, done;
__ test(scratch, Immediate(kSmiTagMask)); __ test(number, Immediate(kSmiTagMask));
__ j(zero, &load_smi, not_taken); __ j(zero, &load_smi, not_taken);
__ fld_d(FieldOperand(scratch, HeapNumber::kValueOffset)); __ fld_d(FieldOperand(number, HeapNumber::kValueOffset));
__ jmp(&done); __ jmp(&done);
__ bind(&load_smi); __ bind(&load_smi);
__ sar(scratch, kSmiTagSize); __ sar(number, kSmiTagSize);
__ push(scratch); __ push(number);
__ fild_s(Operand(esp, 0)); __ fild_s(Operand(esp, 0));
__ pop(scratch); __ pop(number);
__ bind(&done); __ bind(&done);
} }