From 87cf0bdddf10b0d896c2120ebcccf49687eff491 Mon Sep 17 00:00:00 2001 From: Lei Zhang Date: Thu, 23 Dec 2021 09:42:51 -0800 Subject: [PATCH] Remove many superfluous STL includes in headers. MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Use grep to check for obviously unneeded includes. e.g. headers that include but does not contain "std::vector". Change-Id: I43a9e9f01e072fd495918d28ca4cdad5cfa0294c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3354400 Reviewed-by: Marja Hölttä Reviewed-by: Toon Verwaest Reviewed-by: Michael Lippautz Commit-Queue: Lei Zhang Cr-Commit-Position: refs/heads/main@{#78613} --- include/cppgc/default-platform.h | 1 - include/v8-isolate.h | 1 - include/v8-snapshot.h | 2 -- include/v8-traced-handle.h | 2 -- include/v8.h | 1 - src/asmjs/asm-parser.h | 1 - src/base/vlq-base64.h | 3 ++- src/codegen/arm/assembler-arm.h | 1 - src/codegen/arm64/assembler-arm64.h | 2 -- src/codegen/arm64/macro-assembler-arm64.h | 2 -- src/codegen/external-reference-table.h | 2 -- src/compiler-dispatcher/lazy-compile-dispatcher.h | 1 - src/compiler/backend/instruction.h | 2 -- src/compiler/effect-control-linearizer.h | 2 -- src/compiler/property-access-builder.h | 2 -- src/compiler/zone-stats.h | 1 - src/debug/debug-scopes.h | 2 -- src/debug/interface-types.h | 2 -- src/debug/wasm/gdb-server/packet.h | 2 +- src/debug/wasm/gdb-server/transport.h | 3 +-- src/execution/futex-emulation.h | 2 -- src/flags/flags.h | 2 -- src/heap/code-object-registry.h | 1 - src/heap/heap.h | 1 - src/heap/invalidated-slots-inl.h | 2 -- src/heap/local-factory.h | 3 --- src/heap/marking-worklist-inl.h | 1 - src/heap/new-spaces.h | 1 - src/heap/spaces.h | 1 - src/heap/sweeper.h | 1 - src/inspector/v8-runtime-agent-impl.h | 2 -- src/interpreter/bytecodes.h | 1 - src/objects/value-serializer.h | 1 - src/parsing/parse-info.h | 2 -- src/profiler/profiler-listener.h | 1 - src/snapshot/serializer.h | 2 -- src/snapshot/snapshot.h | 2 ++ src/torque/declaration-visitor.h | 1 - src/torque/kythe-data.h | 2 -- src/torque/type-visitor.h | 2 -- src/torque/types.h | 1 - src/wasm/streaming-decoder.h | 1 - src/web-snapshot/web-snapshot.h | 1 - 43 files changed, 6 insertions(+), 63 deletions(-) diff --git a/include/cppgc/default-platform.h b/include/cppgc/default-platform.h index 2ccdeddd83..b1864f9b09 100644 --- a/include/cppgc/default-platform.h +++ b/include/cppgc/default-platform.h @@ -6,7 +6,6 @@ #define INCLUDE_CPPGC_DEFAULT_PLATFORM_H_ #include -#include #include "cppgc/platform.h" #include "libplatform/libplatform.h" diff --git a/include/v8-isolate.h b/include/v8-isolate.h index 9da24d47e3..7a0dc831be 100644 --- a/include/v8-isolate.h +++ b/include/v8-isolate.h @@ -10,7 +10,6 @@ #include #include -#include #include "cppgc/common.h" #include "v8-array-buffer.h" // NOLINT(build/include_directory) diff --git a/include/v8-snapshot.h b/include/v8-snapshot.h index ed02598c36..2400357cf6 100644 --- a/include/v8-snapshot.h +++ b/include/v8-snapshot.h @@ -5,8 +5,6 @@ #ifndef INCLUDE_V8_SNAPSHOT_H_ #define INCLUDE_V8_SNAPSHOT_H_ -#include - #include "v8-internal.h" // NOLINT(build/include_directory) #include "v8-local-handle.h" // NOLINT(build/include_directory) #include "v8config.h" // NOLINT(build/include_directory) diff --git a/include/v8-traced-handle.h b/include/v8-traced-handle.h index 7db34a970c..8a3c661419 100644 --- a/include/v8-traced-handle.h +++ b/include/v8-traced-handle.h @@ -11,10 +11,8 @@ #include #include -#include #include #include -#include #include "v8-internal.h" // NOLINT(build/include_directory) #include "v8-local-handle.h" // NOLINT(build/include_directory) diff --git a/include/v8.h b/include/v8.h index dd91f880b7..1067d3eb24 100644 --- a/include/v8.h +++ b/include/v8.h @@ -19,7 +19,6 @@ #include #include -#include #include "cppgc/common.h" #include "v8-array-buffer.h" // NOLINT(build/include_directory) diff --git a/src/asmjs/asm-parser.h b/src/asmjs/asm-parser.h index 1aa6365817..05105be91d 100644 --- a/src/asmjs/asm-parser.h +++ b/src/asmjs/asm-parser.h @@ -6,7 +6,6 @@ #define V8_ASMJS_ASM_PARSER_H_ #include -#include #include "src/asmjs/asm-scanner.h" #include "src/asmjs/asm-types.h" diff --git a/src/base/vlq-base64.h b/src/base/vlq-base64.h index 5d8633798b..1a06750d08 100644 --- a/src/base/vlq-base64.h +++ b/src/base/vlq-base64.h @@ -5,7 +5,8 @@ #ifndef V8_BASE_VLQ_BASE64_H_ #define V8_BASE_VLQ_BASE64_H_ -#include +#include +#include #include "src/base/base-export.h" diff --git a/src/codegen/arm/assembler-arm.h b/src/codegen/arm/assembler-arm.h index 4cce50f795..ca4a79469a 100644 --- a/src/codegen/arm/assembler-arm.h +++ b/src/codegen/arm/assembler-arm.h @@ -43,7 +43,6 @@ #include #include -#include #include "src/base/numbers/double.h" #include "src/base/small-vector.h" diff --git a/src/codegen/arm64/assembler-arm64.h b/src/codegen/arm64/assembler-arm64.h index 0a436c3570..0862b7e81a 100644 --- a/src/codegen/arm64/assembler-arm64.h +++ b/src/codegen/arm64/assembler-arm64.h @@ -6,10 +6,8 @@ #define V8_CODEGEN_ARM64_ASSEMBLER_ARM64_H_ #include -#include #include #include -#include #include "src/base/optional.h" #include "src/codegen/arm64/constants-arm64.h" diff --git a/src/codegen/arm64/macro-assembler-arm64.h b/src/codegen/arm64/macro-assembler-arm64.h index e99d9ba8ab..3a54283d5a 100644 --- a/src/codegen/arm64/macro-assembler-arm64.h +++ b/src/codegen/arm64/macro-assembler-arm64.h @@ -9,8 +9,6 @@ #ifndef V8_CODEGEN_ARM64_MACRO_ASSEMBLER_ARM64_H_ #define V8_CODEGEN_ARM64_MACRO_ASSEMBLER_ARM64_H_ -#include - #include "src/base/bits.h" #include "src/codegen/arm64/assembler-arm64.h" #include "src/codegen/bailout-reason.h" diff --git a/src/codegen/external-reference-table.h b/src/codegen/external-reference-table.h index 0bf42477ae..4f8839aa53 100644 --- a/src/codegen/external-reference-table.h +++ b/src/codegen/external-reference-table.h @@ -5,8 +5,6 @@ #ifndef V8_CODEGEN_EXTERNAL_REFERENCE_TABLE_H_ #define V8_CODEGEN_EXTERNAL_REFERENCE_TABLE_H_ -#include - #include "src/builtins/accessors.h" #include "src/builtins/builtins.h" #include "src/codegen/external-reference.h" diff --git a/src/compiler-dispatcher/lazy-compile-dispatcher.h b/src/compiler-dispatcher/lazy-compile-dispatcher.h index f50678c83b..ce5919dc51 100644 --- a/src/compiler-dispatcher/lazy-compile-dispatcher.h +++ b/src/compiler-dispatcher/lazy-compile-dispatcher.h @@ -6,7 +6,6 @@ #define V8_COMPILER_DISPATCHER_LAZY_COMPILE_DISPATCHER_H_ #include -#include #include #include #include diff --git a/src/compiler/backend/instruction.h b/src/compiler/backend/instruction.h index a42579aef8..a90600b686 100644 --- a/src/compiler/backend/instruction.h +++ b/src/compiler/backend/instruction.h @@ -5,10 +5,8 @@ #ifndef V8_COMPILER_BACKEND_INSTRUCTION_H_ #define V8_COMPILER_BACKEND_INSTRUCTION_H_ -#include #include #include -#include #include "src/base/compiler-specific.h" #include "src/base/numbers/double.h" diff --git a/src/compiler/effect-control-linearizer.h b/src/compiler/effect-control-linearizer.h index 97467391e2..33af60cd5b 100644 --- a/src/compiler/effect-control-linearizer.h +++ b/src/compiler/effect-control-linearizer.h @@ -5,8 +5,6 @@ #ifndef V8_COMPILER_EFFECT_CONTROL_LINEARIZER_H_ #define V8_COMPILER_EFFECT_CONTROL_LINEARIZER_H_ -#include - #include "src/handles/handles.h" namespace v8 { diff --git a/src/compiler/property-access-builder.h b/src/compiler/property-access-builder.h index d86037a578..77ef1bab35 100644 --- a/src/compiler/property-access-builder.h +++ b/src/compiler/property-access-builder.h @@ -5,8 +5,6 @@ #ifndef V8_COMPILER_PROPERTY_ACCESS_BUILDER_H_ #define V8_COMPILER_PROPERTY_ACCESS_BUILDER_H_ -#include - #include "src/base/optional.h" #include "src/codegen/machine-type.h" #include "src/compiler/js-heap-broker.h" diff --git a/src/compiler/zone-stats.h b/src/compiler/zone-stats.h index c69c00f9a0..0949c431b6 100644 --- a/src/compiler/zone-stats.h +++ b/src/compiler/zone-stats.h @@ -6,7 +6,6 @@ #define V8_COMPILER_ZONE_STATS_H_ #include -#include #include #include "src/common/globals.h" diff --git a/src/debug/debug-scopes.h b/src/debug/debug-scopes.h index 7cc0e1ed16..a499a6f399 100644 --- a/src/debug/debug-scopes.h +++ b/src/debug/debug-scopes.h @@ -5,8 +5,6 @@ #ifndef V8_DEBUG_DEBUG_SCOPES_H_ #define V8_DEBUG_DEBUG_SCOPES_H_ -#include - #include "src/debug/debug-frames.h" #include "src/parsing/parse-info.h" diff --git a/src/debug/interface-types.h b/src/debug/interface-types.h index 1737d5e4f1..7fb95ef1fe 100644 --- a/src/debug/interface-types.h +++ b/src/debug/interface-types.h @@ -6,8 +6,6 @@ #define V8_DEBUG_INTERFACE_TYPES_H_ #include -#include -#include #include "include/v8-function-callback.h" #include "include/v8-local-handle.h" diff --git a/src/debug/wasm/gdb-server/packet.h b/src/debug/wasm/gdb-server/packet.h index 4308081cad..87b5b6b91a 100644 --- a/src/debug/wasm/gdb-server/packet.h +++ b/src/debug/wasm/gdb-server/packet.h @@ -6,7 +6,7 @@ #define V8_DEBUG_WASM_GDB_SERVER_PACKET_H_ #include -#include + #include "src/base/macros.h" namespace v8 { diff --git a/src/debug/wasm/gdb-server/transport.h b/src/debug/wasm/gdb-server/transport.h index 9d44f81acb..279c8d3d84 100644 --- a/src/debug/wasm/gdb-server/transport.h +++ b/src/debug/wasm/gdb-server/transport.h @@ -6,7 +6,7 @@ #define V8_DEBUG_WASM_GDB_SERVER_TRANSPORT_H_ #include -#include + #include "src/base/macros.h" #include "src/debug/wasm/gdb-server/gdb-remote-util.h" @@ -31,7 +31,6 @@ typedef int socklen_t; #include #include #include -#include typedef int SocketHandle; diff --git a/src/execution/futex-emulation.h b/src/execution/futex-emulation.h index 5b4320c5b0..4747ed5f48 100644 --- a/src/execution/futex-emulation.h +++ b/src/execution/futex-emulation.h @@ -7,8 +7,6 @@ #include -#include - #include "include/v8-persistent-handle.h" #include "src/base/atomicops.h" #include "src/base/lazy-instance.h" diff --git a/src/flags/flags.h b/src/flags/flags.h index 07a29af5d4..c13cfcf184 100644 --- a/src/flags/flags.h +++ b/src/flags/flags.h @@ -5,8 +5,6 @@ #ifndef V8_FLAGS_FLAGS_H_ #define V8_FLAGS_FLAGS_H_ -#include - #include "src/common/globals.h" namespace v8 { diff --git a/src/heap/code-object-registry.h b/src/heap/code-object-registry.h index f0ae334d99..b0a2dbd4cf 100644 --- a/src/heap/code-object-registry.h +++ b/src/heap/code-object-registry.h @@ -5,7 +5,6 @@ #ifndef V8_HEAP_CODE_OBJECT_REGISTRY_H_ #define V8_HEAP_CODE_OBJECT_REGISTRY_H_ -#include #include #include "src/base/macros.h" diff --git a/src/heap/heap.h b/src/heap/heap.h index ceb6e9d05c..9b4583c20b 100644 --- a/src/heap/heap.h +++ b/src/heap/heap.h @@ -7,7 +7,6 @@ #include #include -#include #include #include #include diff --git a/src/heap/invalidated-slots-inl.h b/src/heap/invalidated-slots-inl.h index 7d28b750e2..ffe1a4ba9b 100644 --- a/src/heap/invalidated-slots-inl.h +++ b/src/heap/invalidated-slots-inl.h @@ -5,8 +5,6 @@ #ifndef V8_HEAP_INVALIDATED_SLOTS_INL_H_ #define V8_HEAP_INVALIDATED_SLOTS_INL_H_ -#include - #include "src/heap/invalidated-slots.h" #include "src/heap/spaces.h" #include "src/objects/objects-inl.h" diff --git a/src/heap/local-factory.h b/src/heap/local-factory.h index 84275ef9d2..0ede831f39 100644 --- a/src/heap/local-factory.h +++ b/src/heap/local-factory.h @@ -5,9 +5,6 @@ #ifndef V8_HEAP_LOCAL_FACTORY_H_ #define V8_HEAP_LOCAL_FACTORY_H_ -#include -#include - #include "src/base/logging.h" #include "src/common/globals.h" #include "src/handles/handles.h" diff --git a/src/heap/marking-worklist-inl.h b/src/heap/marking-worklist-inl.h index 6e28bd687e..0f7f7b683f 100644 --- a/src/heap/marking-worklist-inl.h +++ b/src/heap/marking-worklist-inl.h @@ -5,7 +5,6 @@ #define V8_HEAP_MARKING_WORKLIST_INL_H_ #include -#include #include "src/heap/cppgc-js/cpp-marking-state-inl.h" #include "src/heap/marking-worklist.h" diff --git a/src/heap/new-spaces.h b/src/heap/new-spaces.h index ed45de3a96..a51b3e4c12 100644 --- a/src/heap/new-spaces.h +++ b/src/heap/new-spaces.h @@ -6,7 +6,6 @@ #define V8_HEAP_NEW_SPACES_H_ #include -#include #include #include "src/base/macros.h" diff --git a/src/heap/spaces.h b/src/heap/spaces.h index 84ee3dbb3c..f4f3305f67 100644 --- a/src/heap/spaces.h +++ b/src/heap/spaces.h @@ -7,7 +7,6 @@ #include #include -#include #include "src/base/iterator.h" #include "src/base/macros.h" diff --git a/src/heap/sweeper.h b/src/heap/sweeper.h index f6a362d596..0b0db9e4b5 100644 --- a/src/heap/sweeper.h +++ b/src/heap/sweeper.h @@ -5,7 +5,6 @@ #ifndef V8_HEAP_SWEEPER_H_ #define V8_HEAP_SWEEPER_H_ -#include #include #include diff --git a/src/inspector/v8-runtime-agent-impl.h b/src/inspector/v8-runtime-agent-impl.h index 0ab39e8da2..8524525ce9 100644 --- a/src/inspector/v8-runtime-agent-impl.h +++ b/src/inspector/v8-runtime-agent-impl.h @@ -32,11 +32,9 @@ #define V8_INSPECTOR_V8_RUNTIME_AGENT_IMPL_H_ #include -#include #include #include "include/v8-persistent-handle.h" -// #include "include/v8-function-callback.h" #include "src/base/macros.h" #include "src/inspector/protocol/Forward.h" #include "src/inspector/protocol/Runtime.h" diff --git a/src/interpreter/bytecodes.h b/src/interpreter/bytecodes.h index f01f4f412c..2b2e5faed7 100644 --- a/src/interpreter/bytecodes.h +++ b/src/interpreter/bytecodes.h @@ -8,7 +8,6 @@ #include #include #include -#include #include "src/common/globals.h" #include "src/interpreter/bytecode-operands.h" diff --git a/src/objects/value-serializer.h b/src/objects/value-serializer.h index c6363e67c6..4cf13130d8 100644 --- a/src/objects/value-serializer.h +++ b/src/objects/value-serializer.h @@ -6,7 +6,6 @@ #define V8_OBJECTS_VALUE_SERIALIZER_H_ #include -#include #include "include/v8-value-serializer.h" #include "src/base/compiler-specific.h" diff --git a/src/parsing/parse-info.h b/src/parsing/parse-info.h index 162395f448..9a942a21a1 100644 --- a/src/parsing/parse-info.h +++ b/src/parsing/parse-info.h @@ -5,9 +5,7 @@ #ifndef V8_PARSING_PARSE_INFO_H_ #define V8_PARSING_PARSE_INFO_H_ -#include #include -#include #include "src/base/bit-field.h" #include "src/base/export-template.h" diff --git a/src/profiler/profiler-listener.h b/src/profiler/profiler-listener.h index bcdd1b7b05..a06654820f 100644 --- a/src/profiler/profiler-listener.h +++ b/src/profiler/profiler-listener.h @@ -6,7 +6,6 @@ #define V8_PROFILER_PROFILER_LISTENER_H_ #include -#include #include "include/v8-profiler.h" #include "src/logging/code-events.h" diff --git a/src/snapshot/serializer.h b/src/snapshot/serializer.h index b049af5776..44c5e49eca 100644 --- a/src/snapshot/serializer.h +++ b/src/snapshot/serializer.h @@ -5,8 +5,6 @@ #ifndef V8_SNAPSHOT_SERIALIZER_H_ #define V8_SNAPSHOT_SERIALIZER_H_ -#include - #include "src/codegen/external-reference-encoder.h" #include "src/common/assert-scope.h" #include "src/execution/isolate.h" diff --git a/src/snapshot/snapshot.h b/src/snapshot/snapshot.h index bfa03fd478..d8caff0dc4 100644 --- a/src/snapshot/snapshot.h +++ b/src/snapshot/snapshot.h @@ -5,6 +5,8 @@ #ifndef V8_SNAPSHOT_SNAPSHOT_H_ #define V8_SNAPSHOT_SNAPSHOT_H_ +#include + #include "include/v8-snapshot.h" // For StartupData. #include "src/common/assert-scope.h" #include "src/common/globals.h" diff --git a/src/torque/declaration-visitor.h b/src/torque/declaration-visitor.h index befbfae6ae..b03d49fb34 100644 --- a/src/torque/declaration-visitor.h +++ b/src/torque/declaration-visitor.h @@ -5,7 +5,6 @@ #ifndef V8_TORQUE_DECLARATION_VISITOR_H_ #define V8_TORQUE_DECLARATION_VISITOR_H_ -#include #include #include "src/base/macros.h" diff --git a/src/torque/kythe-data.h b/src/torque/kythe-data.h index ba18841949..c335d484ed 100644 --- a/src/torque/kythe-data.h +++ b/src/torque/kythe-data.h @@ -5,8 +5,6 @@ #ifndef V8_TORQUE_KYTHE_DATA_H_ #define V8_TORQUE_KYTHE_DATA_H_ -#include - #include "src/torque/ast.h" #include "src/torque/contextual.h" #include "src/torque/global-context.h" diff --git a/src/torque/type-visitor.h b/src/torque/type-visitor.h index 205e842cc7..f183be3a7a 100644 --- a/src/torque/type-visitor.h +++ b/src/torque/type-visitor.h @@ -5,8 +5,6 @@ #ifndef V8_TORQUE_TYPE_VISITOR_H_ #define V8_TORQUE_TYPE_VISITOR_H_ -#include - #include "src/torque/ast.h" #include "src/torque/types.h" diff --git a/src/torque/types.h b/src/torque/types.h index 45b7390f2b..c49753be21 100644 --- a/src/torque/types.h +++ b/src/torque/types.h @@ -6,7 +6,6 @@ #define V8_TORQUE_TYPES_H_ #include -#include #include #include #include diff --git a/src/wasm/streaming-decoder.h b/src/wasm/streaming-decoder.h index 6f4601b9f4..463d29f4d0 100644 --- a/src/wasm/streaming-decoder.h +++ b/src/wasm/streaming-decoder.h @@ -10,7 +10,6 @@ #define V8_WASM_STREAMING_DECODER_H_ #include -#include #include "src/base/macros.h" #include "src/base/vector.h" diff --git a/src/web-snapshot/web-snapshot.h b/src/web-snapshot/web-snapshot.h index 25a76f3572..e512f0ac65 100644 --- a/src/web-snapshot/web-snapshot.h +++ b/src/web-snapshot/web-snapshot.h @@ -6,7 +6,6 @@ #define V8_WEB_SNAPSHOT_WEB_SNAPSHOT_H_ #include -#include #include "src/handles/handles.h" #include "src/objects/value-serializer.h"