AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

Revert of Use GCC for snapshot_toolchain when is_clang=false. (patchset #1 id:1 of https://codereview.chromium.org/1809643003/ )

Browse Source 
Reason for revert:
Blocks roll: https://codereview.chromium.org/1874173002/

Original issue's description:
> Use GCC for snapshot_toolchain when is_clang=false.
>
> Currently, snapshot_toolchain is hardcoded to use a clang host
> toolchain. Use a GCC toolchain if is_clang is false.
>
> Revert this when this is root-caused (see crbug.com/601486)
>
> LOG=Y
> BUG=601486
>
> Committed: https://crrev.com/920370d1a910681bf464bd91aced316058ea2f6c
> Cr-Commit-Position: refs/heads/master@{#35341}

TBR=jochen@chromium.org,alokp@chromium.org,dpranke@chromium.org,slan@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=601486
LOG=Y

Review URL: https://codereview.chromium.org/1873113002

Cr-Commit-Position: refs/heads/master@{#35372}
This commit is contained in:
hablich 2016-04-11 01:28:08 -07:00 committed by Commit bot
parent a6fd69ac29
commit 87e7cd7f3f
1 changed files with 2 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
snapshot_toolchain.gni
View File

@ -33,17 +33,9 @@
# configurations v8 runs on.
if (host_cpu == "x64" && host_os == "linux") {
if (target_cpu == "arm" || target_cpu == "mipsel" || target_cpu == "x86") {
if (is_clang) {
snapshot_toolchain = "//build/toolchain/linux:clang_x86"
} else {
snapshot_toolchain = "//build/toolchain/linux:x86"
}
snapshot_toolchain = "//build/toolchain/linux:clang_x86"
} else if (target_cpu == "x64" || target_cpu == "arm64" || target_cpu == "mips64el") {
if (is_clang) {
snapshot_toolchain = "//build/toolchain/linux:clang_x64"
} else {
snapshot_toolchain = "//build/toolchain/linux:x64"
}
snapshot_toolchain = "//build/toolchain/linux:clang_x64"
} else {
assert(false, "Need environment for this arch: $target_cpu")
}