AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

Turn off incremental wrapper tracing by default

Browse Source 
With the flag on the blink tests fail because blink is not prepared for v8
behaving incrementally.

In order to land and enable incremental wrapper tracing both in v8 smoothly and
blink we need to:

1. Land ScriptWrappableVisitorTest (http://crrev.com/2301213003)
2. Land write barriers implementation with more tests
3. Land write barriers installations
4. Enable incremental wrapper tracing on v8 side
5. Canary the heck out of this :)

This way the tests should be passing and chrome shouldn't crash at any given
moment.

LOG=no
BUG=468240
NOTRY=true

Review-Url: https://codereview.chromium.org/2299193003
Cr-Commit-Position: refs/heads/master@{#39132}
This commit is contained in:
hlopko 2016-09-02 05:06:02 -07:00 committed by Commit bot
parent 6a892bb451
commit 883e0e7036
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/flag-definitions.h
View File

@ -727,7 +727,7 @@ DEFINE_BOOL(age_code, true,
"track un-executed functions to age code and flush only "
"old code (required for code flushing)")
DEFINE_BOOL(incremental_marking, true, "use incremental marking")
DEFINE_BOOL(incremental_marking_wrappers, true,
DEFINE_BOOL(incremental_marking_wrappers, false,
"use incremental marking for marking wrappers")
DEFINE_INT(min_progress_during_incremental_marking_finalization, 32,
"keep finalizing incremental marking as long as we discover at "