AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[jumbo] Rename one of the ResolveRenames

Browse Source 
Recently* a second ResolveRenames appeared in
typed-optimization.cc. In some extreme (non-default) jumbo
builds that file shared translation unit (and thus anonymous
namespace) with load-elimination.cc which also has a
ResolveRenames which is slightly different.

To avoid that name clash and failed compilation, this
renames ResolveRenames -> ResolveRenamesForOpt.

*) It appeared in
 https://chromium-review.googlesource.com/c/v8/v8/+/1609803

Change-Id: Ia175468a8e978e93e95da1d28f74cee8dce253d2
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1615465
Commit-Queue: Tobias Tebbi <tebbi@chromium.org>
Reviewed-by: Tobias Tebbi <tebbi@chromium.org>
Auto-Submit: Daniel Bratell <bratell@opera.com>
Cr-Commit-Position: refs/heads/master@{#61655}
This commit is contained in:
Daniel Bratell 2019-05-16 19:17:47 +02:00 committed by Commit Bot
parent 9a6f52f519
commit 8852d85487
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/compiler/typed-optimization.cc
View File

@ -113,7 +113,7 @@ base::Optional<MapRef> GetStableMapFromObjectType(JSHeapBroker* broker,
return {};
}
Node* ResolveRenames(Node* node) {
Node* ResolveSameValueRenames(Node* node) {
while (true) {
switch (node->opcode()) {
case IrOpcode::kCheckHeapObject:
@ -527,7 +527,7 @@ Reduction TypedOptimization::ReduceSameValue(Node* node) {
Node* const rhs = NodeProperties::GetValueInput(node, 1);
Type const lhs_type = NodeProperties::GetType(lhs);
Type const rhs_type = NodeProperties::GetType(rhs);
if (ResolveRenames(lhs) == ResolveRenames(rhs)) {
if (ResolveSameValueRenames(lhs) == ResolveSameValueRenames(rhs)) {
if (NodeProperties::GetType(node).IsNone()) {
return NoChange();
}