AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

v8: Remove obsolete TODO(gyp) frmo snapshot_toolchain.gni

Browse Source 
The GN build by now supports more cross build scenarios than
the gyp build ever did.

Change-Id: Ibe1c1ab75a0c6f9d32831a016dc119b27cff002b
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4012138
Auto-Submit: Nico Weber <thakis@chromium.org>
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Commit-Queue: Michael Achenbach <machenbach@chromium.org>
Cr-Commit-Position: refs/heads/main@{#84106}
This commit is contained in:
Nico Weber 2022-11-08 01:15:32 +00:00 committed by V8 LUCI CQ
parent 2269d4ff0a
commit 88be9a05cc
1 changed files with 0 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
gni/snapshot_toolchain.gni
View File

@ -44,10 +44,6 @@ declare_args() {
#
# There are test cases for this code posted as an attachment to
# https://crbug.com/625353.
#
# TODO(GYP): Currently only regular (non-cross) compiles, and cross-compiles
# from x64 hosts to Intel, ARM, or MIPS targets, are implemented. Add support
# for the other supported configurations.
if (v8_snapshot_toolchain == "") {
if (current_os == host_os && current_cpu == host_cpu) {