AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

Add a method to convert unsigned C integer into V8 Integer.

Browse Source 
Review URL: http://codereview.chromium.org/260002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3013 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
This commit is contained in:
antonm@chromium.org 2009-10-02 15:51:07 +00:00
parent 2c51696fc3
commit 8925e8af0a
3 changed files with 99 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
include/v8.h
View File

@ -1063,6 +1063,7 @@ class V8EXPORT Number : public Primitive {
class V8EXPORT Integer : public Number {
public:
static Local<Integer> New(int32_t value);
static inline Local<Integer> New(uint32_t value);
int64_t Value() const;
static inline Integer* Cast(v8::Value* obj);
private:
@ -3026,6 +3027,16 @@ Number* Number::Cast(v8::Value* value) {
}
Local<Integer> Integer::New(uint32_t value) {
// If highest bit is not set, chances are it's SMI.
bool could_be_smi = (value & (1 << 31)) == 0;
if (could_be_smi) {
return Integer::New(static_cast<int32_t>(value));
}
return Local<Integer>::Cast(Number::New(value));
}
Integer* Integer::Cast(v8::Value* value) {
#ifdef V8_ENABLE_CHECKS
CheckCast(value);

19
src/checks.h
View File

@ -80,6 +80,25 @@ static inline void CheckEqualsHelper(const char* file, int line,
}
}
// Helper function used by the CHECK_EQ function when given int64_t
// arguments. Should not be called directly.
static inline void CheckEqualsHelper(const char* file, int line,
const char* expected_source,
int64_t expected,
const char* value_source,
int64_t value) {
if (expected != value) {
// Sorry, printing int64_t in a fanky hex way,
// that's our mother tongue after all :)
V8_Fatal(file, line,
"CHECK_EQ(%s, %s) failed\n#"
" Expected: 0x%08x%08x\n# Found: 0x%08x%08x",
expected_source, value_source,
uint32_t(expected >> 32), uint32_t(expected),
uint32_t(value >> 32), uint32_t(value));
}
}
// Helper function used by the CHECK_NE function when given int
// arguments. Should not be called directly.

69
test/cctest/test-api.cc
View File

@ -702,6 +702,75 @@ THREADED_TEST(PropertyHandler) {
}
THREADED_TEST(TinyInteger) {
v8::HandleScope scope;
LocalContext env;
int32_t value = 239;
Local<v8::Integer> value_obj = v8::Integer::New(value);
CHECK_EQ(int64_t(value), value_obj->Value());
}
THREADED_TEST(BigSmiInteger) {
v8::HandleScope scope;
LocalContext env;
int32_t value = (1 << 30) - 1;
CHECK(i::Smi::IsValid(value));
CHECK(!i::Smi::IsValid(value + 1));
Local<v8::Integer> value_obj = v8::Integer::New(value);
CHECK_EQ(int64_t(value), value_obj->Value());
}
THREADED_TEST(BigInteger) {
v8::HandleScope scope;
LocalContext env;
int32_t value = (1 << 30) + 1;
CHECK(!i::Smi::IsValid(value));
Local<v8::Integer> value_obj = v8::Integer::New(value);
CHECK_EQ(int64_t(value), value_obj->Value());
}
THREADED_TEST(TinyUnsignedInteger) {
v8::HandleScope scope;
LocalContext env;
uint32_t value = 239;
Local<v8::Integer> value_obj = v8::Integer::New(value);
CHECK_EQ(int64_t(value), value_obj->Value());
}
THREADED_TEST(BigUnsignedSmiInteger) {
v8::HandleScope scope;
LocalContext env;
uint32_t value = (1 << 30) - 1;
CHECK(i::Smi::IsValid(value));
CHECK(!i::Smi::IsValid(value + 1));
Local<v8::Integer> value_obj = v8::Integer::New(value);
CHECK_EQ(int64_t(value), value_obj->Value());
}
THREADED_TEST(BigUnsignedInteger) {
v8::HandleScope scope;
LocalContext env;
uint32_t value = (1 << 30) + 1;
CHECK(!i::Smi::IsValid(value));
Local<v8::Integer> value_obj = v8::Integer::New(value);
CHECK_EQ(int64_t(value), value_obj->Value());
}
THREADED_TEST(OutOfSignedRangeUnsignedInteger) {
v8::HandleScope scope;
LocalContext env;
uint32_t value = uint32_t(0xffffffff);
Local<v8::Integer> value_obj = v8::Integer::New(value);
CHECK_EQ(int64_t(value), value_obj->Value());
}
THREADED_TEST(Number) {
v8::HandleScope scope;
LocalContext env;