AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

Fix disassembly comment for CallFunctionStub.

Browse Source 
The comment was printing the entire minor key but labeling it with 'argc'.

Review URL: http://codereview.chromium.org/6120001

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@6208 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
This commit is contained in:
kmillikin@chromium.org 2011-01-06 14:13:40 +00:00
parent 1152cab095
commit 8945e02d86
2 changed files with 12 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
src/code-stubs.h
View File

@ -1,4 +1,4 @@
// Copyright 2006-2008 the V8 project authors. All rights reserved. // Copyright 2011 the V8 project authors. All rights reserved.
// Redistribution and use in source and binary forms, with or without // Redistribution and use in source and binary forms, with or without
// modification, are permitted provided that the following conditions are // modification, are permitted provided that the following conditions are
// met: // met:
@ -723,6 +723,10 @@ class CallFunctionStub: public CodeStub {
void Generate(MacroAssembler* masm); void Generate(MacroAssembler* masm);
static int ExtractArgcFromMinorKey(int minor_key) {
return ArgcBits::decode(minor_key);
}
private: private:
int argc_; int argc_;
InLoopFlag in_loop_; InLoopFlag in_loop_;
@ -754,11 +758,6 @@ class CallFunctionStub: public CodeStub {
bool ReceiverMightBeValue() { bool ReceiverMightBeValue() {
return (flags_ & RECEIVER_MIGHT_BE_VALUE) != 0; return (flags_ & RECEIVER_MIGHT_BE_VALUE) != 0;
} }
public:
static int ExtractArgcFromMinorKey(int minor_key) {
return ArgcBits::decode(minor_key);
}
}; };

11
src/disassembler.cc
View File

@ -1,4 +1,4 @@
// Copyright 2010 the V8 project authors. All rights reserved. // Copyright 2011 the V8 project authors. All rights reserved.
// Redistribution and use in source and binary forms, with or without // Redistribution and use in source and binary forms, with or without
// modification, are permitted provided that the following conditions are // modification, are permitted provided that the following conditions are
// met: // met:
@ -268,10 +268,13 @@ static int DecodeIt(FILE* f,
Code::Kind2String(kind), Code::Kind2String(kind),
CodeStub::MajorName(major_key, false)); CodeStub::MajorName(major_key, false));
switch (major_key) { switch (major_key) {
case CodeStub::CallFunction: case CodeStub::CallFunction: {
out.AddFormatted("argc = %d", minor_key); int argc =
CallFunctionStub::ExtractArgcFromMinorKey(minor_key);
out.AddFormatted("argc = %d", argc);
break; break;
default: }
default:
out.AddFormatted("minor: %d", minor_key); out.AddFormatted("minor: %d", minor_key);
} }
} }