From 8961287aec102c718a07bbc779ca50f52fc2471a Mon Sep 17 00:00:00 2001 From: Michael Achenbach Date: Thu, 26 Apr 2018 10:34:07 +0200 Subject: [PATCH] [V8] Add back owners check This adds parts of Chromium's PanProjectChecks. We don't add all yet as there is to much chance for the checks to fire on files later. We first need to find a way to run the checks on all files (not only changed ones). NOTRY=true Bug: v8:7689 Change-Id: I747b49a9a362cf76f329e7f743545c6e6cb56f85 Reviewed-on: https://chromium-review.googlesource.com/1029854 Reviewed-by: Yang Guo Commit-Queue: Michael Achenbach Cr-Commit-Position: refs/heads/master@{#52828} --- PRESUBMIT.py | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/PRESUBMIT.py b/PRESUBMIT.py index e6dbb79395..055027c7bb 100644 --- a/PRESUBMIT.py +++ b/PRESUBMIT.py @@ -289,6 +289,13 @@ def _CheckNoProductionCodeUsingTestOnlyFunctions(input_api, output_api): def _CommonChecks(input_api, output_api): """Checks common to both upload and commit.""" results = [] + # TODO(machenbach): Replace some of those checks, e.g. owners and copyright, + # with the canned PanProjectChecks. Need to make sure that the checks all + # pass on all existing files. + results.extend(input_api.canned_checks.CheckOwnersFormat( + input_api, output_api)) + results.extend(input_api.canned_checks.CheckOwners( + input_api, output_api)) results.extend(_CheckCommitMessageBugEntry(input_api, output_api)) results.extend(input_api.canned_checks.CheckPatchFormatted( input_api, output_api))